Skip to content

[#51]: whPullReqTargetRepo can be null #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2021

Conversation

kvanbere
Copy link
Member

@kvanbere kvanbere commented Dec 5, 2021

Issue reference:
#51.

Submission Checklist:

  • Have you followed the guidelines in our Contributing document (for example, is your tree a clean merge)?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission build?
  • Does your submission pass tests?
  • Have you run lints on your code locally prior to submission?
  • Have you updated all of the cabal/nix infrastructure?
  • Is this a breaking change? Have you discussed this?

@kvanbere kvanbere added the bug label Dec 5, 2021
@kvanbere kvanbere added this to the 0.16.0 milestone Dec 5, 2021
@kvanbere kvanbere self-assigned this Dec 5, 2021
@kvanbere kvanbere changed the title [#51] whPullReqTargetRepo can be null (fixes #47) [#51]: whPullReqTargetRepo can be null (fixes #47) Dec 5, 2021
@kvanbere kvanbere linked an issue Dec 5, 2021 that may be closed by this pull request
@kvanbere
Copy link
Member Author

kvanbere commented Dec 5, 2021

@roberth shall I add you to AUTHORS ?

@roberth
Copy link
Contributor

roberth commented Dec 5, 2021

Sure! The more the merrier.

@kvanbere kvanbere merged commit 62ab67f into develop Dec 5, 2021
@kvanbere kvanbere deleted the bugfix/51-headrepo-optional branch December 5, 2021 12:34
@kvanbere kvanbere changed the title [#51]: whPullReqTargetRepo can be null (fixes #47) [#51]: whPullReqTargetRepo can be null Dec 5, 2021
@kvanbere
Copy link
Member Author

kvanbere commented Dec 5, 2021

Ugh, the merge with squash erased the authorship from 9a78a65. Surely that's not normal, otherwise it's a useless feature.

@roberth
Copy link
Contributor

roberth commented Dec 5, 2021

In my experience, git and github work best with merges.

Don't worry about fixing it up.

@kvanbere
Copy link
Member Author

This has been released, thanks @roberth!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

whPullReqTargetRepo can be null
2 participants