Skip to content

[#56]: CheckSuite after field can be null #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2022
Merged

[#56]: CheckSuite after field can be null #55

merged 1 commit into from
Jan 20, 2022

Conversation

AlistairB
Copy link
Contributor

@AlistairB AlistairB commented Jan 19, 2022 •
edited by kvanbere
Loading

Issue reference: Pretty trivial, do I need one?

I just noticed there are cases where the check suite after field is null.

Submission Checklist:

  • Have you followed the guidelines in our Contributing document (for example, is your tree a clean merge)?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission build?
  • Does your submission pass tests?
  • Have you run lints on your code locally prior to submission?
  • Have you updated all of the cabal/nix infrastructure?
  • Is this a breaking change? Have you discussed this?

@kvanbere kvanbere added the bug label Jan 19, 2022
@kvanbere kvanbere added this to the 0.16.0 milestone Jan 19, 2022
@kvanbere kvanbere linked an issue Jan 20, 2022 that may be closed by this pull request
whCheckSuiteAfterSha in CheckSuiteEvent can be null #56
Closed
@kvanbere kvanbere merged commit 7181552 into cuedo:develop Jan 20, 2022
@kvanbere
Copy link
Member

kvanbere commented Jan 20, 2022 •
edited
Loading

A great contribution, tested and passed, thanks for catching this @AlistairB !

Staged for 0.16.0 .

@kvanbere kvanbere changed the title CheckSuite after field can be null [#56]: CheckSuite after field can be null Jan 20, 2022
@kvanbere
Copy link
Member

This has been released. Thanks @AlistairB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AlistairB AlistairB

Labels
bug
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.

whCheckSuiteAfterSha in CheckSuiteEvent can be null
2 participants
@AlistairB @kvanbere