Commit 878676b
authored
Default value for preferred scope setting (#2687)
I got unreliable behavior when we didn't have a default value here.
Turns out that if you don't have a default value get will not actually
return none. It will return a `NoValueType` object and that is evaluated
to true in the if statements so everybody probably has preferred scope
on now. This might be a change to Talon because I can't believe we
didn't catch this earlier.
## Checklist
- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [/] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have not broken the cheatsheet1 parent 8cf3464 commit 878676b
1 file changed
+3
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
45 | | - | |
| 46 | + | |
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
| |||
0 commit comments