Skip to content

Commit a79254c

Browse files
bjaspanBarry Jaspanpre-commit-ci-lite[bot]
authored
Stop using default exports from packages/cursorless-engine/src/processTargets. (#2011)
This removes all default exports from packages/cursorless-engine/src/processTargets. I'm not yet sure if this will actually help me achieve my larger goal but it is a small net improvement in the codebase in any case. --------- Co-authored-by: Barry Jaspan <bjaspan@google.com> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
1 parent 53c76d3 commit a79254c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+84
-106
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"rules": {
3+
"import/no-default-export": ["error"]
4+
}
5+
}

packages/cursorless-engine/src/processTargets/MarkStageFactoryImpl.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ import { StoredTargetMap } from "..";
44
import { Mark } from "../typings/TargetDescriptor";
55
import { MarkStageFactory } from "./MarkStageFactory";
66
import { MarkStage } from "./PipelineStages.types";
7-
import CursorStage from "./marks/CursorStage";
8-
import DecoratedSymbolStage from "./marks/DecoratedSymbolStage";
9-
import ExplicitMarkStage from "./marks/ExplicitMarkStage";
10-
import LineNumberStage from "./marks/LineNumberStage";
11-
import NothingStage from "./marks/NothingStage";
12-
import RangeMarkStage from "./marks/RangeMarkStage";
7+
import { CursorStage } from "./marks/CursorStage";
8+
import { DecoratedSymbolStage } from "./marks/DecoratedSymbolStage";
9+
import { ExplicitMarkStage } from "./marks/ExplicitMarkStage";
10+
import { LineNumberStage } from "./marks/LineNumberStage";
11+
import { NothingStage } from "./marks/NothingStage";
12+
import { RangeMarkStage } from "./marks/RangeMarkStage";
1313
import { StoredTargetStage } from "./marks/StoredTargetStage";
1414
import { TargetMarkStage } from "./marks/TargetMarkStage";
1515

packages/cursorless-engine/src/processTargets/ModifierStageFactoryImpl.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { StoredTargetMap } from "..";
88
import { LanguageDefinitions } from "../languages/LanguageDefinitions";
99
import { ModifierStageFactory } from "./ModifierStageFactory";
1010
import { ModifierStage } from "./PipelineStages.types";
11-
import CascadingStage from "./modifiers/CascadingStage";
11+
import { CascadingStage } from "./modifiers/CascadingStage";
1212
import { ModifyIfUntypedStage } from "./modifiers/ConditionalModifierStages";
1313
import { ContainingScopeStage } from "./modifiers/ContainingScopeStage";
1414
import { EveryScopeStage } from "./modifiers/EveryScopeStage";
@@ -17,27 +17,27 @@ import {
1717
KeepEmptyFilterStage,
1818
} from "./modifiers/FilterStages";
1919
import { HeadStage, TailStage } from "./modifiers/HeadTailStage";
20-
import InstanceStage from "./modifiers/InstanceStage";
20+
import { InstanceStage } from "./modifiers/InstanceStage";
2121
import {
2222
ExcludeInteriorStage,
2323
InteriorOnlyStage,
2424
} from "./modifiers/InteriorStage";
25-
import ItemStage from "./modifiers/ItemStage";
25+
import { ItemStage } from "./modifiers/ItemStage";
2626
import { LeadingStage, TrailingStage } from "./modifiers/LeadingTrailingStages";
2727
import { OrdinalScopeStage } from "./modifiers/OrdinalScopeStage";
2828
import { EndOfStage, StartOfStage } from "./modifiers/PositionStage";
29-
import RangeModifierStage from "./modifiers/RangeModifierStage";
30-
import RawSelectionStage from "./modifiers/RawSelectionStage";
31-
import RelativeScopeStage from "./modifiers/RelativeScopeStage";
32-
import SurroundingPairStage from "./modifiers/SurroundingPairStage";
29+
import { RangeModifierStage } from "./modifiers/RangeModifierStage";
30+
import { RawSelectionStage } from "./modifiers/RawSelectionStage";
31+
import { RelativeScopeStage } from "./modifiers/RelativeScopeStage";
32+
import { SurroundingPairStage } from "./modifiers/SurroundingPairStage";
3333
import { ScopeHandlerFactory } from "./modifiers/scopeHandlers/ScopeHandlerFactory";
34-
import BoundedNonWhitespaceSequenceStage from "./modifiers/scopeTypeStages/BoundedNonWhitespaceStage";
34+
import { BoundedNonWhitespaceSequenceStage } from "./modifiers/scopeTypeStages/BoundedNonWhitespaceStage";
3535
import {
3636
LegacyContainingSyntaxScopeStage,
3737
SimpleContainingScopeModifier,
3838
SimpleEveryScopeModifier,
3939
} from "./modifiers/scopeTypeStages/LegacyContainingSyntaxScopeStage";
40-
import NotebookCellStage from "./modifiers/scopeTypeStages/NotebookCellStage";
40+
import { NotebookCellStage } from "./modifiers/scopeTypeStages/NotebookCellStage";
4141

4242
export class ModifierStageFactoryImpl implements ModifierStageFactory {
4343
constructor(

packages/cursorless-engine/src/processTargets/TargetPipelineRunner.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { Target } from "../typings/target.types";
1515
import { MarkStageFactory } from "./MarkStageFactory";
1616
import { ModifierStageFactory } from "./ModifierStageFactory";
1717
import { MarkStage, ModifierStage } from "./PipelineStages.types";
18-
import ImplicitStage from "./marks/ImplicitStage";
18+
import { ImplicitStage } from "./marks/ImplicitStage";
1919
import { ContainingTokenIfUntypedEmptyStage } from "./modifiers/ConditionalModifierStages";
2020
import { PlainTarget } from "./targets";
2121
import { uniqWithHash } from "../util/uniqWithHash";

packages/cursorless-engine/src/processTargets/marks/CursorStage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import type { MarkStage } from "../PipelineStages.types";
55
import { UntypedTarget } from "../targets";
66
import { getActiveSelections } from "./getActiveSelections";
77

8-
export default class CursorStage implements MarkStage {
8+
export class CursorStage implements MarkStage {
99
constructor(private mark: CursorMark) {}
1010

1111
run(): Target[] {

packages/cursorless-engine/src/processTargets/marks/DecoratedSymbolStage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { Target } from "../../typings/target.types";
33
import { MarkStage } from "../PipelineStages.types";
44
import { UntypedTarget } from "../targets";
55

6-
export default class implements MarkStage {
6+
export class DecoratedSymbolStage implements MarkStage {
77
constructor(
88
private readableHatMap: ReadOnlyHatMap,
99
private mark: DecoratedSymbolMark,

packages/cursorless-engine/src/processTargets/marks/ExplicitMarkStage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { MarkStage } from "../PipelineStages.types";
44
import { UntypedTarget } from "../targets";
55
import { ide } from "../../singletons/ide.singleton";
66

7-
export default class implements MarkStage {
7+
export class ExplicitMarkStage implements MarkStage {
88
constructor(private mark: ExplicitMark) {}
99

1010
run(): Target[] {

packages/cursorless-engine/src/processTargets/marks/ImplicitStage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import type { MarkStage } from "../PipelineStages.types";
44
import { ImplicitTarget } from "../targets";
55
import { getActiveSelections } from "./getActiveSelections";
66

7-
export default class ImplicitStage implements MarkStage {
7+
export class ImplicitStage implements MarkStage {
88
run(): Target[] {
99
return getActiveSelections(ide()).map(
1010
(selection) =>

packages/cursorless-engine/src/processTargets/marks/LineNumberStage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import type { MarkStage } from "../PipelineStages.types";
55
import { createLineTarget } from "../modifiers/scopeHandlers";
66
import { LineTarget } from "../targets";
77

8-
export default class implements MarkStage {
8+
export class LineNumberStage implements MarkStage {
99
constructor(private mark: LineNumberMark) {}
1010

1111
run(): LineTarget[] {

packages/cursorless-engine/src/processTargets/marks/NothingStage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Target } from "../../typings/target.types";
22
import { NothingMark } from "@cursorless/common";
33
import { MarkStage } from "../PipelineStages.types";
44

5-
export default class implements MarkStage {
5+
export class NothingStage implements MarkStage {
66
constructor(private mark: NothingMark) {}
77

88
run(): Target[] {

0 commit comments

Comments
 (0)