Skip to content
This repository was archived by the owner on Jun 19, 2024. It is now read-only.

Conversation

rdprescott
Copy link

add the cappability to insert CommentStmt to debug primitive detection
fix issue where D01 and D03 are implicit

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 88.9% when pulling 63a2ae2 on rdprescott:master into 45372cf on curtacircuitos:master.

@hamiltonkibbe
Copy link
Contributor

Where does outlinecome from in the CamFile.bounds calculation in fa6cc86. That seems to be the only change that breaks the tests.

CamFile should really only ever used as a base class. The bounds method should be overridden everywhere it is subclassed (currently GerberFile and ExcellonFile). I don't see any reason to have an implementation in CamFile except to maybe raise NotImplementedError.

I'll take a look through the rest when I have a bit more time, Thanks for the contribution!

@phsilva
Copy link
Member

phsilva commented Apr 13, 2015

I've started to get code from this PR to fix individual issues (like implicit D01 and D03). Would be good to try to rebase this PR with latest HEAD to see if it possible to split it more than one PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants