Skip to content

Add more explicit typing #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2025
Merged

Conversation

steinmn
Copy link
Contributor

@steinmn steinmn commented Jul 29, 2025

ruff check . now down to 308 errors. part of #258

steinmn added 3 commits July 29, 2025 22:25
Part of custom-components#258 to reduce the number of ruff-issues
In additionto the stated reason of messing with pytest.patch, it also just looks messier.
@steinmn
Copy link
Contributor Author

steinmn commented Jul 29, 2025

@sveinse I took a pass and handled some of the more obvious/simpler ruff-complaints. Up to you if you want to look at this now, or leave it for after 0.8.0 is released.

@sveinse sveinse added code quality Issues related to the quality of the code after-v0.8 labels Jul 30, 2025
@sveinse sveinse added this to the next milestone Aug 2, 2025
@sveinse sveinse removed the next label Aug 2, 2025
Copy link
Collaborator

@sveinse sveinse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sveinse
Copy link
Collaborator

sveinse commented Aug 15, 2025

@steinmn can you please update the branch conflict?

@steinmn
Copy link
Contributor Author

steinmn commented Aug 15, 2025

Done

@sveinse sveinse merged commit 21511ad into custom-components:master Aug 15, 2025
3 checks passed
@sveinse
Copy link
Collaborator

sveinse commented Aug 15, 2025

Merged. Thank you.

@steinmn steinmn deleted the fix-ruff-linting branch August 15, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Issues related to the quality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants