Skip to content

Commit d10b6d7

Browse files
committed
Fix issue where cookies could not be saved without Secure attribute.
1 parent ea80c63 commit d10b6d7

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

data/news/20241022.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"date": "Tue, 22 Oct 2024 00:00:00 GMT",
3+
"bodyText": "news/20241022.md",
4+
"version": "1.9.1"
5+
}

data/news/20241022.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
### Fixed
2+
3+
- issue where settings could not be saved
4+
- due to Firefox now requiring Secure to be set on cookies when SameSite is set to None

src/js/shared/storage.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ class CustomStartStorageCookieStorage {
3939
Cookies.set(this.key, JSON.stringify(obj), {
4040
expires: 365,
4141
/* Must be None so that the page can be loaded in an iframe (like when using https://github.com/methodgrab/firefox-custom-new-tab-page) otherwise the cookies can't be loaded in that iframe?! */
42-
sameSite: 'None'
42+
sameSite: 'None',
43+
secure: true,
4344
});
4445
}
4546
delete() {

0 commit comments

Comments
 (0)