Note: check e.relatedTarget before setting editing: false #2894
+67
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raineorshine Can you please test this branch to see if it resolves #2840 as well as #2841? It's not too terribly likely that the two are directly related, but I have difficulty reproducing #2840 and it would be good to know. |
|
Let me know if you still need me to test this against both issues, since we clarified the steps to reproduce. |
That's OK, I verified that this does not fix #2840. |
|
I copied over the |
raineorshine
approved these changes
Apr 20, 2025
| @@ -272,4 +274,22 @@ describe('mobile only', () => { | |||
| const focusNode = await getSelection().focusNode | |||
| expect(focusNode).toBeUndefined() | |||
| }) | |||
|
|
|||
| describe('when caret moves from inside a note', () => { | |||
| it('cursorForward should move the cursor to the next thought', async () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2841
The
editing({ value: false })action was being dispatched when focus was moved from the note to the thought. I think it must be possible forselection.isActive()to be falseonBlurbeforeonFocusruns on the thought that is getting selected.More testing is required to verify this assertion a little better, and also to ensure that
e.relatedTargetis an acceptable substitute forselection.isActive(). There are some events that may fire with a value ine.relatedTargetsuch as opening the hamburger menu, but basic testing indicates that this works OK.