[+] support variable partition intervals in postgres sink #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19174203732Details
💛 - Coveralls |
pashagolub
changed the title
pashagolub
added
enhancement
Collaborator
|
Thanks. I don't see any new tests and I don't see validation on I'd put additional check into |
pashagolub
force-pushed
the
958-variable-partition-intervals
branch
from
a8a9685 to
9edacf6
Compare
Collaborator
|
fixes #931 as well |
0xgouda
force-pushed
the
958-variable-partition-intervals
branch
from
6c088ac to
4a93038
Compare
`admin.ensure_partition_metric_dbname_time()` acccepts now partition_period interval. The naming format is 'YYYYMMDD' for intervals bigger than 1 day and 'YYYYMMDD_HH24' for hour-based intervals. The function finds the last available partition bound and creates new partition based on it. So it's possible to use mixed length partitions, possibly with scheduler based on monitored source and/or metrics.
- Pass the param directly o need for additional parsing pgx already expects a string
pashagolub
force-pushed
the
958-variable-partition-intervals
branch
from
6426231 to
c1a32f8
Compare
0xgouda
added a commit
that referenced
this pull request
Nov 10, 2025
* [+] allow to specify interval for Postgres partitioning `admin.ensure_partition_metric_dbname_time()` acccepts now partition_period interval. The naming format is 'YYYYMMDD' for intervals bigger than 1 day and 'YYYYMMDD_HH24' for hour-based intervals. The function finds the last available partition bound and creates new partition based on it. So it's possible to use mixed length partitions, possibly with scheduler based on monitored source and/or metrics. * Add new `PartitionInterval` cli parameter. * Use `PartitionInterval` parameter in `EnsureMetricDbnameTime()` * Mention `--partition-interval` in docs. * Add validation logic for `PartitionInterval` * Add test for `PartitionInterval` validation * Test actual partitions creation * Add example usage of `--partition-interval` in docs. --------- Co-authored-by: Pavlo Golub <pavlo.golub@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--partition-intervalflag that accepts a PostgreSQL interval string and uses it as the time range in the 3rd-level partition in metric tables.closes: #958
closes: #931