[+] support custom configs for maintenance tasks #1018
Merged
+372
−153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modify `--retention` to accept PostgreSQL interval string.
0xgouda
force-pushed
the
994-maintenance-interval
branch
from
a5dc045 to
03c5be3
Compare
Pull Request Test Coverage Report for Build 19297656396Details
💛 - Coveralls |
pashagolub
reviewed
Nov 11, 2025
pashagolub
reviewed
Nov 11, 2025
pashagolub
added
enhancement
0xgouda
added a commit
to ArnaudDecatec/pgwatch
that referenced
this pull request
Nov 12, 2025
…#1018) * Introduce `--maintenance-interval` flag - modify `--retention` to accept PostgreSQL interval string. * Use new flags to control deletion and maintenance tasks. * Test `MaintainUniqueSources()` and `DeleteOldPartitions()` * update docs reference page to mention new flag. * run `DeleteOldPartitions()` with `retentionInterval` not `maintenanceInterval` * Rename test * Capitalize `set` in flag description. * Fix typo in comment * rename `CmdOpts.Retention` to `RetentionInterval` * add `PostgresWriter.scheduleJob()` function --------- Co-authored-by: Pavlo Golub <pavlo.golub@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--maintenance-intervalflag that accepts a PostgreSQL interval string and controls the interval at which to run maintenance tasks. 0 disables it.--retentionto accept PostgreSQL interval string instead oftime.Duration, and use the zero value as an indicator to disable it as well.This assumes that migrating
--retentionfromtime.Durationto astringvalidated as a PostgreSQL interval will be backward-compatible.closes: #994