-
Notifications
You must be signed in to change notification settings - Fork 30
Tree view platform badge #2159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree view platform badge #2159
Conversation
Thanks @harleenkaur2003! We'll take a look at this soon. |
Hey @hjoliver @MetRonnie ! |
Sorry for the delay @harleenkaur2003 - we are just slammed with higher priority issues at the moment. However, this is quite a small code change so maybe we can take a look very soon... |
This looks good to me. Tested with a platform group, of two faked platforms: # global.cylc
[platforms]
[[one]]
hosts = localhost
install target = localhost
[[two]]
hosts = localhost
install target = localhost
[platform groups]
[[nums]]
platforms = one, two @cylc/core -
|
Thank you for the review and feedback! Regarding the platform name style, I used brackets and a smaller font to visually separate the platform from the task name, but I'm happy to align it with mock-up style if preferred - just let me know! Looking forward to @MetRonnie's review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @harleenkaur2003, thanks for your contribution. I've added some suggestions
… class as requested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Waiting for approval from @hjoliver )
Hey @hjoliver ! |
Apologies @harleenkaur2003 - it just slipped off my radar screen! Taking a look today... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @harleenkaur2003 🎉
Title:
Display Latest Job Platform on Unexpanded Task Node
Description:
Screenshot:

Checklist:
CONTRIBUTING.md
and added my name as a Code Contributor.