chore: update .scrollIntoView() example #5161
Draft
+78,019
−72,338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: Needs screenshot update of the command log. |
Updates test description to match previous test specifics against example.cypress.io
* Fix TypeScript capitalization in Changelog * Correct TypeScript in 13.12.0 changelog
* docs: fix typo in test-isolation.mdx * fix typo in test-isolation.mdx replace "when ran" with "when run" Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> --------- Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
* List CI Docker examples * Correct typo
* feat: first pass at adding angular signals documentation (#5841) * feat: first pass at adding angular signals documentation * take suggestions from code review * remove info from mount overview for angular-signals * use contraction for does not * overhaul the angular signals documentation to be more user friendly on usage and not so technical * empty commit to kick off ci * changelog for 13.13.0 --------- Co-authored-by: Cacie Prins <cacie@cypress.io>
* Rework Docker prerequisites * correct statement about unzip with Node.js
* Remove outdated workshops * Delete examples workshop page
As we introduce JSX syntax here, the component support file needs/should have the .jsx file extension.
* Changing name of 'Free' plan to 'Starter' plan This PR will coincide with changes that will be published to our cypress.io website. The benefits and features remain the same, but the name is changing from 'free' to 'starter' * 2nd round of fixes for converting free to starter Addressed the two screen caps raised by review, and the 'free' reference on the FAQ page
…5876) * Update what is supported in Test Replay to be accurate and point to issues * reword question * fix typo * lint fix * Update to be a bit more readable with objects * run lint after running yarn with updates * lint fix * remove period
… retroactively supported operating systems (#5877) * update documentation to display required minimum version of glibc and retroactively supported operating systems * update documentation to apply suggestions * add min glibc version in linux prereqs * attempt to reword glibc min requirement
* feat: tooling, guidelines update - Wopee.io for visual testing * chore: fixing formatting issue * chore: fixing formatting issue
* update docs for new accessibility configuration and branch review capabilities * add empty state * Update docs/accessibility/core-concepts/compare-reports.mdx Co-authored-by: Jennifer Shehane <jennifer@cypress.io> * fix missing word * fix bad link * fix link for real * lint fix * fix headings * update diff title * update overview --------- Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
…re (#6199) * clarify that dynamic values cannot be provided to Cypress.require * Update docs/api/cypress-api/require.mdx Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> --------- Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
* break up tests * Update cypress/e2e/all_app_pages.cy.ts * 6 machines but suspect this needs adjusted * 6 machines * try this * .
* Add Windows 11 24H2 arm64 support * min cypress 14.5.0 required * changelog ref relative
* WIP files for new configuration properties. * Fixing lint errors. Adding 'assert' example. * More formatting * make minor updates and add intro --------- Co-authored-by: marktnoonan <mark@cypress.io>
* update supported providers for the Results API * wip docs for Cypress rules * add detail, update changelog * changelog updates * improve alt text * update wording for website crawling * tweaks * lint fix * fix typo in rule id * remove temp file * Update docs/accessibility/core-concepts/cypress-rules.mdx Co-authored-by: Tyler Biethman <tbiethman@gmail.com> * Update docs/accessibility/core-concepts/cypress-rules.mdx Co-authored-by: Tyler Biethman <tbiethman@gmail.com> * fix a typo * update rule text * add more detail * add more detail * lint fix * add more detail * Update docs/accessibility/core-concepts/cypress-rules.mdx Co-authored-by: Tyler Biethman <tbiethman@gmail.com> * Update docs/accessibility/core-concepts/cypress-rules.mdx Co-authored-by: Tyler Biethman <tbiethman@gmail.com> * remove unfinished example * changelog * Update docs/accessibility/core-concepts/cypress-rules.mdx Co-authored-by: Jennifer Shehane <jennifer@cypress.io> * Update docs/accessibility/core-concepts/cypress-rules.mdx Co-authored-by: Tyler Biethman <tbiethman@gmail.com> * Update docs/accessibility/core-concepts/cypress-rules.mdx Co-authored-by: Jennifer Shehane <jennifer@cypress.io> * add overall explainer at the top * Update docs/accessibility/core-concepts/cypress-rules.mdx Co-authored-by: Tyler Biethman <tbiethman@gmail.com> --------- Co-authored-by: Tyler Biethman <tbiethman@gmail.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
marktnoonan
approved these changes
Jul 11, 2025
There was a problem hiding this comment.
@emilyrohrbough I just came across this by chance, seems fine to merge?
|
It can't be merged until it is fixed to change the moved contents on https://docs.cypress.io/api/commands/scrollIntoView#Scrolling |
|
Thanks @MikeMcC399 - I noticed that and the TODO for the screenshot of the command log (but only after I approved). I'll tidy this up at some point today and we can get it in. |
marktnoonan
requested changes
Jul 11, 2025
cypress-documentation
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress-documentation
|
| Branch Review |
correct-scrollIntoView-example
|
| Run status |
|
| Run duration | 05m 17s |
| Commit |
|
| Committer | marktnoonan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
309
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
10.99%
|
|
|---|---|
|
Untested elements
|
2445
|
|
Tested elements
|
3
|
Accessibility
96.99%
|
|
|---|---|
|
Failed rules
|
1 critical
3 serious
4 moderate
0 minor
|
|
Failed elements
|
26
|
|
It may be easier to close this PR and create as new one, as the changes are quite trivial and the target file has changed. It's a bit scary seeing 300+ files changed, even if this PR is in draft! |
|
Haha, yes, I did a suspicious rebase on my side - we'll make sure the diff is accurate one way or another before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.scrollIntoView() is unsafe to chain further - update example to show valid example
Closes #5002
Closes #5160