-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Added plugin for mock/fake geolocation and timezone #6220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added plugin for mock/fake geolocation and timezone #6220
Conversation
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest version of Cypress is 14.x and it's expected to release Cypress 15.x soon.
does not include Cypress 14:
"peerDependencies": {
"cypress": "^12.0.0 || ^13.0.0"
},
https://github.com/pradapjackie/cypress-geolocation-locale-faker/blob/main/.github/workflows/ci.yml tests with an old version of Cypress
test:
runs-on: ubuntu-latest
container: cypress/included:13.7.3
Your package.json does not include populated package-json fields
- homepage should be https://github.com/pradapjackie/cypress-geolocation-locale-faker#readme
- repository for the command npm repo should refer to https://github.com/pradapjackie/cypress-geolocation-locale-faker (use the npm documentation for the exact syntax)
- bugs for the command npm bugs should be https://github.com/pradapjackie/cypress-geolocation-locale-faker/issues
Note: It's up to the Cypress.io team to review your submission and decide whether to accept it. I'm an external contributor so I can only give you some advice. I can't approve anything.
Edit: resolved: Generally they will only accept submissions if the CLA agreement is signed.
@MikeMcC399 Thank you for the valuable feedback , I will apply the changes before End of today GST. |
The Cypress.io team is very busy with the next release of Cypress, so it may take them some time until they respond to you after you make your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you completed all the open actions, and the following commands now all produce results 👍🏻
npm view cypress-geolocation-locale-faker homepage
npm view cypress-geolocation-locale-faker
npm repo cypress-geolocation-locale-faker
I suggest to use also the following, however this is not a prerequisite for Cypress, just a suggestion for you:
- npm pkg fix to check and fix any errors
- add your releases to https://github.com/pradapjackie/cypress-geolocation-locale-faker/releases
You'll need to wait for the Cypress.io team now. That completes what I can do for you. Good luck!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving here, to remove the flag that I requested changes.
As mentioned before, I don't have the authority to actually approve the merge.
Plugin Name:
cypress-geolocation-locale-faker
Plugin Link: https://www.npmjs.com/package/cypress-geolocation-locale-faker
GitHub Repository: https://github.com/pradapjackie/cypress-geolocation-locale-faker
✅ Plugin Quality Checklist
cypress/included:14.5.1
)README.md
cy.visit()
with faked geolocation, locale, and timezonestart-server-and-test
andcypress/included
Docker image – CI Link📋 Plugin Submission Requirements