Skip to content

spike: cjs to esm strategy #32052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

AtofStryker
Copy link
Contributor

  • Closes

Additional details

Steps to test

How has the user experience changed?

PR Tasks

@AtofStryker AtofStryker changed the base branch from develop to release/15.0.0 July 17, 2025 18:29
@AtofStryker AtofStryker force-pushed the spike/esm_goalposting_with_cursor branch from 4c38341 to c23239b Compare July 17, 2025 20:45
Copy link

cypress bot commented Jul 17, 2025

cypress    Run #63924

Run Properties:  status check failed Failed #63924  •  git commit cb1b55640d: test
Project cypress
Branch Review spike/esm_goalposting_with_cursor
Run status status check failed Failed #63924
Run duration 19m 11s
Commit git commit cb1b55640d: test
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 10
Tests that did not run due to a developer annotating a test with .skip  Pending 1105
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26511
View all changes introduced in this branch ↗︎
UI Coverage  45.01%
  Untested elements 188  
  Tested elements 158  
Accessibility  97.82%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 109  

Tests for review

Failed  cypress/e2e/error-handling.cy.ts • 2 failed tests • launchpad-e2e

View Output

Test Artifacts
Error handling > using bundler: "vite" with missing config > displays informative error about what went wrong and where we looked Test Replay Screenshots
... > handles missing webpack.config Test Replay Screenshots
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  e2e/origin/cookie_behavior.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
... > misc > domains > attaches subdomain and TLD cookies when making subdomain requests Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
... > errors > throws when route is never resolved Test Replay
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay

The first 5 flaky specs are shown, see all 10 specs in Cypress Cloud.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: TypeScript File Extension Causes Test Failures

The run_child_fixture.ts file incorrectly uses require.resolve() with a hardcoded .ts extension for require_async_child.ts. require.resolve() expects compiled .js files, not TypeScript source files, which will cause runtime failures. This also creates an inconsistency with ProjectConfigIpc.ts, which uses environment-based conditional logic to resolve .js in production and .ts in development, potentially causing the test to fail in production environments or when CYPRESS_INTERNAL_ENV is 'production'.

packages/server/test/unit/plugins/child/run_child_fixture.ts#L4-L5

const REQUIRE_ASYNC_CHILD_PATH = require.resolve('@packages/server/lib/plugins/child/require_async_child.ts')

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant