-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore: (studio) AI status updates #32511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
cypress
|
Project |
cypress
|
Branch Review |
studio-ai-states
|
Run status |
|
Run duration | 19m 45s |
Commit |
|
Committer | Adam Stone-Lord |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
14
|
|
1102
|
|
0
|
|
26666
|
View all changes introduced in this branch ↗︎ |
UI Coverage
44.73%
|
|
---|---|
|
189
|
|
157
|
Accessibility
97.71%
|
|
---|---|
|
4 critical
8 serious
2 moderate
2 minor
|
|
110
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: React Component Fails to Update with New Props
The StudioPanel.vue
component passes new props (hasRequestedProjectAccess
, userProjectStatusStore
) to the child React component. Without watch
statements for these props, similar to canAccessStudioAI
and cloudStudioSessionId
, the React component won't re-render when their values change. This means the Studio panel may not update to reflect the latest state.
packages/app/src/studio/StudioPanel.vue#L141-L143
cypress/packages/app/src/studio/StudioPanel.vue
Lines 141 to 143 in 3f7b08b
}, | |
name: 'app', | |
}) |
packages/app/src/studio/StudioPanel.vue#L93-L95
cypress/packages/app/src/studio/StudioPanel.vue
Lines 93 to 95 in 3f7b08b
// If vue tracks it (e.g. using a ref) it creates proxies that do not play nicely with React in | |
// production | |
let reactRoot = containerReactRootMap.get(container.value) |
packages/app/src/studio/StudioPanel.vue#L102-L104
cypress/packages/app/src/studio/StudioPanel.vue
Lines 102 to 104 in 3f7b08b
reactRoot?.render(panel) | |
} | |
Additional details
In order to handle cloud/project authentication states, we need to pass the user cloud states to the studio panel.
Steps to test
See the services PR
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?