Skip to content

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Jun 27, 2025

Description

This PR addresses CVE-2025-50181 by adding versioning specifications for urllib3 so it may be used with compatible versions of Python.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

📚 Documentation preview 📚: https://pycytominer--551.org.readthedocs.build/en/551/

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.42%. Comparing base (4af3e47) to head (4043fba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   94.42%   94.42%           
=======================================
  Files          57       57           
  Lines        3193     3193           
=======================================
  Hits         3015     3015           
  Misses        178      178           
Flag Coverage Δ
unittests 94.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d33bs d33bs marked this pull request as ready for review June 27, 2025 21:14
@d33bs d33bs requested a review from gwaybio July 1, 2025 16:40
@d33bs
Copy link
Member Author

d33bs commented Jul 2, 2025

Thanks @gwaybio !

@d33bs
Copy link
Member Author

d33bs commented Jul 2, 2025

Finding that s3fs blocks the installation of the proper version of urllib3 so I'm going to hold off on a merge here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants