Fix recursive dir cache invalidation bug

Author: iychoi

fs/cache.go

@@ -160,7 +160,7 @@ func (cache *FileSystemCache) RemoveDirEntryCache(path string, recursive bool) {
 func (cache *FileSystemCache) RemoveParentDirEntryCache(path string, recursive bool) {
 	if cache.config.InvalidateParentEntryCacheImmediately {
 		parentPath := util.GetIRODSPathDirname(path)
-		cache.RemoveDirEntryCache(parentPath, true)
+		cache.RemoveDirEntryCache(parentPath, recursive)
 	}
 }
 

fs/fs_cache.go

@@ -191,7 +191,7 @@ func (fs *FileSystem) invalidateCacheForFileCreate(path string) {
 	fs.cache.RemoveNegativeEntryCache(path)
 
 	// parent dir's entry also changes
-	fs.cache.RemoveParentDirEntryCache(path, true)
+	fs.cache.RemoveParentDirEntryCache(path, false)
 	// parent dir's dir entry also changes
 	parentPath := util.GetIRODSPathDirname(path)
 	parentDirEntries := fs.cache.GetDirCache(parentPath)

test/testcases/dummy.go

@@ -7,6 +7,7 @@ import (
 	"testing"
 
 	"github.com/cyverse/go-irodsclient/test/server"
+	"github.com/rs/xid"
 	"golang.org/x/xerrors"
 )
 
@@ -79,9 +80,11 @@ func CreateSampleFilesAndDirs(t *testing.T, server *server.IRODSTestServer, dest
 
 	// create random files
 	baseRecord := 100
+	id := xid.New().String()
+
 	for i := 0; i < numFiles; i++ {
 		filesize := int64((i + 1) * 62 * baseRecord)
-		filename := fmt.Sprintf("test_file_%d.bin", filesize)
+		filename := fmt.Sprintf("test_file_%s_%d.bin", id, filesize)
 
 		tempPath, err := CreateLocalTestFile(t, filename, filesize)
 		if err != nil {
@@ -104,7 +107,7 @@ func CreateSampleFilesAndDirs(t *testing.T, server *server.IRODSTestServer, dest
 
 	// create random directories
 	for i := 0; i < numDirs; i++ {
-		dirname := fmt.Sprintf("test_dir_%d", i)
+		dirname := fmt.Sprintf("test_dir_%s_%d", id, i)
 
 		irodsPath := dest + "/" + dirname
 		err = fs.MakeDir(irodsPath, true)