fixes #194 - out-of-range RemoveRow to throw exception instead of segfaulting

Author: d99kris

CMakeLists.txt

@@ -187,6 +187,7 @@ if(RAPIDCSV_BUILD_TESTS)
   if(HAS_CODECVT)
     add_unit_test(test101)
   endif()
+  add_unit_test(test102)
 
   # perf tests
   add_perf_test(ptest001)

src/rapidcsv.h

@@ -2,7 +2,7 @@
  * rapidcsv.h
  *
  * URL:      https://github.com/d99kris/rapidcsv
- * Version:  8.89
+ * Version:  8.90
  *
  * Copyright (C) 2017-2025 Kristofer Berggren
  * All rights reserved.
@@ -1045,7 +1045,17 @@ namespace rapidcsv
     void RemoveRow(const size_t pRowIdx)
     {
       const size_t dataRowIdx = GetDataRowIndex(pRowIdx);
-      mData.erase(mData.begin() + static_cast<int>(dataRowIdx));
+      if (dataRowIdx < mData.size())
+      {
+        mData.erase(mData.begin() + static_cast<int>(dataRowIdx));
+      }
+      else
+      {
+        const std::string errStr = "row out of range: " +
+          std::to_string(pRowIdx);
+        throw std::out_of_range(errStr);
+      }
+
       UpdateRowNames();
     }
 

tests/test102.cpp

@@ -0,0 +1,46 @@
+// test102.cpp - exception message removing out-of-range row
+
+#include <rapidcsv.h>
+#include "unittest.h"
+
+int main()
+{
+  int rv = 0;
+
+  std::string csv =
+    "-,A,B,C,D\n"
+    "1,3,9,81,6561\n"
+    "2,4,16,256\n"
+    "3,9,81,6561\n"
+  ;
+
+  std::string path = unittest::TempPath();
+  unittest::WriteFile(path, csv);
+
+  try
+  {
+    rapidcsv::Document doc(path, rapidcsv::LabelParams(0, 0));
+
+    doc.RemoveRow("1");
+    unittest::ExpectEqual(std::string, doc.GetRowName(0), "2");
+
+    doc.RemoveRow("3");
+    unittest::ExpectEqual(std::string, doc.GetRowName(0), "2");
+
+    // doc has row 2 (0) now, thus 1 is out of range.
+    ExpectExceptionMsg(doc.RemoveRow(1), std::out_of_range,
+                       "row out of range: 1");
+
+    ExpectExceptionMsg(doc.RemoveRow("1"), std::out_of_range,
+                       "row not found: 1");
+  }
+  catch (const std::exception& ex)
+  {
+    std::cout << ex.what() << std::endl;
+    rv = 1;
+  }
+
+  unittest::DeleteFile(path);
+
+  return rv;
+}