Bulk: remove skipIfOnline method from PinManagerActivity #7786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: as per ticket #10647 some files are showing skipped when trying to stage them Modification: removal of skipIfOnline method. To create a permanent pin use lifetime=-1 AND lifetimeUnit=MILLISECONDS. Result: files are stageable Acked-by:Tigran Mkrtchyan Target: master, 10.2, 11.0 Require-book: no Require-notes: no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: as per ticket #10647 some files are showing skipped when trying to stage them
Modification: removal of skipIfOnline method. To create a permanent pin use lifetime=-1 AND lifetimeUnit=MILLISECONDS.
Result: files are stageable
Acked-by:Tigran Mkrtchyan
Target: master, 10.2, 11.0
Require-book: no
Require-notes: no