When setting default_country to Germany, Phonelib incorrectly returns numbers as German

[mgibson8]

When setting the default country like so..

Phonelib.default_country = "DE"

Phonelib appears to return almost all numbers I tested as German numbers. Out of the 67 numbers I tried, from 60 different countries only 3 returned correctly using the following code, the rest being returned as Germany.

Phonelib.parse(number).country

[daddyz]

@mgibson8 It's hard to determine whether number is valid or not in case of Germany. Valid number can be from 5 to 15 digits after the country code. Such regex is really awesome.
I can provide you with additional setting like prefer country detection prior to default country parsing, meaning phonelib will try to detect country by prefix, and in case it won't be able to parse as valid number will failover to default country.
Will it suite your needs?

[daddyz]

@mgibson8 there is now a Phonelib.strict_double_prefix_check that can help to overcome this issue. Anyway if you can share examples please.

[fynsta]

[1] pry(main)> Phonelib.default_country = nil
=> nil
[2] pry(main)> Phonelib.parse('​+41900 123 123').country
=> "CH"
[3] pry(main)> Phonelib.default_country = 'DE'
=> "DE"
[4] pry(main)> Phonelib.parse('​+41900 123 123').country
=> "DE"
[5] pry(main)> Phonelib.strict_double_prefix_check = true
=> true
[6] pry(main)> Phonelib.parse('​+41900 123 123').country
=> "DE"

@daddyz The strict_double_prefix_check option does not seem to do fix this issue. Or am I misunderstanding anything here? I would expect a number with a '+41' prefix to first be checked for the swiss country regex, and then for the default country.

[ur5us]

@fynsta I’m not sure what’s going on there but there’s something wrong with your string which might actually expose a bug with sanitizing @daddyz. The following 2 lines are not the same:

Phonelib.parse('​+41900 123 123').country => "ID"
Phonelib.parse('+41900 123 123').country => "CH"

The first string has an extra character (zero width space, s. https://codepoints.net/U+200b) before the + character, s.

'​+41900 123 123'.codepoints
=> [8203, 43, 52, 49, 57, 48, 48, 32, 49, 50, 51, 32, 49, 50, 51]