add <Activity> example #154
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,65 +1,65 @@ | ||
| { | ||
| "name": "docs", | ||
| "version": "2.5.7", | ||
| "private": true, | ||
| "scripts": { | ||
| "build": "next build --turbo", | ||
| "dev": "next dev --turbo", | ||
| "start": "next start", | ||
| "postinstall": "fumadocs-mdx", | ||
| "registry:build": "shadcn build", | ||
| "clean": "rm -rf .turbo .next node_modules" | ||
| }, | ||
| "dependencies": { | ||
| "@hookform/resolvers": "^5.2.2", | ||
| "@radix-ui/colors": "^3.0.0", | ||
| "@radix-ui/react-accordion": "^1.2.12", | ||
| "@radix-ui/react-collapsible": "^1.1.12", | ||
| "@radix-ui/react-label": "^2.1.7", | ||
| "@radix-ui/react-popover": "^1.1.15", | ||
| "@radix-ui/react-radio-group": "^1.3.8", | ||
| "@radix-ui/react-scroll-area": "^1.2.10", | ||
| "@radix-ui/react-slot": "^1.2.3", | ||
| "@radix-ui/react-tabs": "^1.1.13", | ||
| "@stepperize/react": "workspace:*", | ||
| "@stepperize/solid": "workspace:*", | ||
| "@stepperize/vue": "workspace:*", | ||
| "arktype": "^2.1.22", | ||
| "class-variance-authority": "^0.7.1", | ||
| "clsx": "^2.1.1", | ||
| "fumadocs-core": "15.8.3", | ||
| "fumadocs-mdx": "12.0.2", | ||
| "fumadocs-twoslash": "3.1.8", | ||
| "fumadocs-typescript": "4.0.11", | ||
| "fumadocs-ui": "15.8.3", | ||
| "geist": "1.5.1", | ||
| "hast-util-to-jsx-runtime": "^2.3.6", | ||
| "lucide-react": "^0.544.0", | ||
| "motion": "^12.23.22", | ||
| "next": "16.0.0-beta.0", | ||
| "react": "catalog:", | ||
| "react-dom": "catalog:", | ||
| "react-hook-form": "^7.64.0", | ||
| "shadcn": "3.4.0", | ||
| "shiki": "3.13.0", | ||
| "solid-js": "^1.9.9", | ||
| "tailwind-merge": "^3.3.1", | ||
| "ts-morph": "27.0.0", | ||
| "tw-animate-css": "^1.4.0", | ||
| "twoslash": "^0.3.4", | ||
| "valibot": "^1.1.0", | ||
| "zod": "^4.1.11" | ||
| }, | ||
| "devDependencies": { | ||
| "@fumadocs/cli": "^1.0.2", | ||
| "@tailwindcss/postcss": "^4.1.14", | ||
| "@types/mdx": "^2.0.13", | ||
| "@types/node": "24.7.0", | ||
| "@types/react": "catalog:", | ||
| "@types/react-dom": "catalog:", | ||
| "@types/react-syntax-highlighter": "^15.5.13", | ||
| "postcss": "^8.5.6", | ||
| "tailwindcss": "^4.1.14", | ||
| "typescript": "catalog:" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| "use client"; | ||
|
|
||
| import * as React from "react"; | ||
|
|
||
| import { defineStepper } from "@/registry/new-york/blocks/stepper-with-activity/components/ui/stepper"; | ||
| import { Button } from "@/registry/new-york/ui/button"; | ||
|
|
||
| const { Stepper, useStepper } = defineStepper( | ||
| { | ||
| id: "step-1", | ||
| title: "Step 1", | ||
| }, | ||
| { | ||
| id: "step-2", | ||
| title: "Step 2", | ||
| }, | ||
| { | ||
| id: "step-3", | ||
| title: "Step 3", | ||
| } | ||
| ); | ||
|
|
||
| export function StepperWithActivity() { | ||
| return ( | ||
| <Stepper.Provider className="space-y-4" variant="horizontal"> | ||
| {({ methods }) => ( | ||
| <React.Fragment> | ||
| <Stepper.Navigation> | ||
| {methods.all.map((step) => ( | ||
| <Stepper.Step | ||
| key={step.id} | ||
| of={step.id} | ||
| onClick={() => methods.goTo(step.id)} | ||
| > | ||
| <Stepper.Title>{step.title}</Stepper.Title> | ||
| </Stepper.Step> | ||
| ))} | ||
| </Stepper.Navigation> | ||
| <Wrapper /> | ||
| <Stepper.Controls> | ||
| {!methods.isLast && ( | ||
| <Button | ||
| type="button" | ||
| variant="secondary" | ||
| onClick={methods.prev} | ||
| disabled={methods.isFirst} | ||
| > | ||
| Previous | ||
| </Button> | ||
| )} | ||
| <Button onClick={methods.isLast ? methods.reset : methods.next}> | ||
| {methods.isLast ? "Reset" : "Next"} | ||
| </Button> | ||
| </Stepper.Controls> | ||
| </React.Fragment> | ||
| )} | ||
| </Stepper.Provider> | ||
| ); | ||
| } | ||
|
|
||
| const Wrapper = () => { | ||
| const { current } = useStepper(); | ||
|
|
||
| return ( | ||
| <> | ||
| <React.Activity mode={current.id === "step-1" ? "visible" : "hidden"}> | ||
| <Content id={current.id} /> | ||
| </React.Activity> | ||
| <React.Activity mode={current.id === "step-2" ? "visible" : "hidden"}> | ||
| <Content id={current.id} /> | ||
| </React.Activity> | ||
| <React.Activity mode={current.id === "step-3" ? "visible" : "hidden"}> | ||
| <Content id={current.id} /> | ||
| </React.Activity> | ||
| </> | ||
| ); | ||
| }; | ||
|
Owner
There was a problem hiding this comment. You can achieve this in a simpler way, like const Wrapper = () => {
const { current } = useStepper();
return (
<>
{steps.map((stepId) => (
<React.Activity
key={stepId}
mode={current.id === stepId ? "visible" : "hidden"}
>
<Content id={current.id} />
</React.Activity>
))}
</>
);
};Getting the
Author
There was a problem hiding this comment. ah ya fair callout, originally it was rendering a different component for each step but simplified it to use the basic component |
||
|
|
||
| const Content = ({ id }: { id: string }) => { | ||
| return ( | ||
| <Stepper.Panel className="h-[200px] content-center rounded border bg-secondary text-secondary-foreground p-8"> | ||
| <p className="text-xl font-normal">Content for {id}</p> | ||
| </Stepper.Panel> | ||
| ); | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, don't update the next package to the beta version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe Next 16 has been released yet and afaik this is the version that React 19.2 is included in which is when Activity is introduced.
Totally fine if you don't merge while it's still in beta but just wanted to get this PR open.
If you're aware of a lower version of Next that includes React 19.2, happy to downgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The library does not depend on NextJS, so I think you could use the Activity API without any issues because the react version in the repo is the new one. I haven't tested it yet, but I don't think you'll have any problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, unfortunately I get this error when it's a lower next version. When I log
React.versionyou can see19.2.0-canary-0bdb9206-20250818logged so it's possible the 19.2.0 set in the catalog is not getting resolved correctlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm yea I see. Well, in that case I wonder if we can just document this use case without a preview and just add a sub section in the hook docs: https://stepperize.vercel.app/docs/react/api-references/hook#rendering-methods
Would be great to have a live preview, but I don’t like the idea of use a very early beta version of NextJS affecting all the docs app. This could generate otros unexpected issues in other libraries related to fumadocs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry haven't had time to get back to this. Saw the new version of next and fumadocs is stable release. Would you want to hold this PR until that's upgraded?