Use matchgen slice matcher for better build times
#108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The slice matcher now allows nested single arm `match` statements to be collapsed into one slice match, which gives significantly better build times, though it hurts run time performance a bit.
Essentially no change in performance.
A little bit slower in the least important ways.
danielparks
force-pushed
the
matchgen-flat-hybrid
branch
from
8680096 to
0aab52b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
matchgenslice matcher for better build timesThe slice matcher now allows nested single arm
matchstatements to becollapsed into one slice match, which gives significantly better build
times, though it hurts run time performance a bit.
Benchmark: matchgen tree matcher in slice mode without collapsing.
Benchmark: matchgen tree matcher in slice mode with collapsing
A little bit slower in the least important ways.