Bug in ScrollViewWithStickyHeader when navigationBarHeight is greater than headerMinHeight

[dusiema]

I think, I found a bug in ScrollViewWithStickyHeader for cases where the navigationBarHeight is greater than the specified headerMinHeight.

navigationBarHeight is determined from proxy.safeAreaInsets.top and depends on the iPhone model (and if it has a notch or an island or neither).

There is a preview in ScrollViewWithStickyHeader which sets the headerMinHeight to 150 currently.
When you set it to e.g. 60 the error appears. Then the frame of the clear color determines the height of the sticky header and not the defined headerMinHeight.

A fix is to only set the height of the clear color when headerMinHeight is not set. I'll provide a PR.

[dusiema]

Maybe this isn't a bug after all?

[danielsaidi]

Hi @dusiema

I wouldn't say that it's a bug per se, rather a best effort implementation that may have unforeseen side-effects ;) If you have a way that makes it behave better, I'd love to merge it.

[dusiema]

Hi Daniel,

:)
I opened a PR here 25
Have a look yourself by changing the headerMinHeight to something below the navigationBarHeight (on an iPhone 16 with an island navigationBarHeight is around 100.

[danielsaidi]

Perfect, thank you! I have merged it and will release it soon.

[danielsaidi]

Hi @dusiema

I found a bug in this, so I have to roll it back.

When I set headerHeight to 250 and headerMinHeight to 150, this code results in:

[danielsaidi]

This has been fixed in the upcoming 0.7 release.