Modify crypto_withdraw signature #359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no_destination_tag to stick to coinbase pro API signature.
mcardillo55
requested changes
Oct 27, 2020
| data=json.dumps(params)) | ||
|
|
||
| def crypto_withdraw(self, amount, currency, crypto_address): | ||
| def crypto_withdraw(self, amount, currency, crypto_address, destination_tag, no_destination_tag=True): |
There was a problem hiding this comment.
We should have a default argument for destination_tag as well, for currencies that do not support them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add 2 parameters destination_tag and no_destination_tag to stick to coinbase pro API signature.
The destination tag is used by XRP and XLM currencies, currencies that support destination tag. If destination tag not needed, then the flag no_destination_tag must be set to True.
I tested the crpyto_withdraw this morning in the master and didn't worked for XLM currencies, so I forked the project, update the code and tested it. It worked fine with in production.