Skip to content

Modify crypto_withdraw signature #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modify crypto_withdraw signature #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions cbpro/authenticated_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,13 +870,16 @@ def coinbase_withdraw(self, amount, currency, coinbase_account_id):
return self._send_message('post', '/withdrawals/coinbase-account',
data=json.dumps(params))

def crypto_withdraw(self, amount, currency, crypto_address):
def crypto_withdraw(self, amount, currency, crypto_address, destination_tag, no_destination_tag=True):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a default argument for destination_tag as well, for currencies that do not support them.

""" Withdraw funds to a crypto address.

Args:
amount (Decimal): The amount to withdraw
currency (str): The type of currency (eg. 'BTC')
crypto_address (str): Crypto address to withdraw to.
destination_tag (str): A destination tag for currencies that support one (XRP and XLM for now)
no_destination_tag (bool): A boolean flag to opt out of using a destination tag for currencies that support
one. This is required when not providing a destination tag.

Returns:
dict: Withdraw details. Example::
Expand All @@ -887,9 +890,13 @@ def crypto_withdraw(self, amount, currency, crypto_address):
}

"""

params = {'amount': amount,
'currency': currency,
'crypto_address': crypto_address}
'crypto_address': crypto_address,
'destination_tag': destination_tag,
'no_destination_tag': no_destination_tag
}
return self._send_message('post', '/withdrawals/crypto',
data=json.dumps(params))

Expand Down