feat: support subscribeMode field on pulsar #3831
Open
+198
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
7 tasks
Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
…ulsar-subscription-mode
|
@ericsyh - Is there an issue number for this PR? |
@msfussell sorry i missed the issue create before, just created a new issue of #3832 and linked on this PR. |
mikeee
reviewed
May 28, 2025
| } | ||
| } | ||
|
|
||
| func getSubscriptionMode(subsModeStr string) pulsar.SubscriptionMode { |
There was a problem hiding this comment.
I would like to see the addition of tests for this function to ensure future changes don't cause regressions
Co-authored-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
|
@nelson-parente @mikeee Could you help review again? cc @yaron2 @JoshVanL help review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #3832
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: