Moving an image does not include sidecar text file #19160
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
TurboGit
added
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution proposal for issue #19097.
I am not sure if the new function _move_extra_file() is acceptable in this way, but I wanted to avoid duplicate coding as much as possible.
The complexity comes from the fact that apparently it is possible to also change the name of an image while moving, at least from a lua script, and the extension for sidecar text and audio file could be in lower or upper case letters. I thought it right to keep the extension.
This is my first attempt to contribute to darktable, so please bear with me, if I made obvious mistakes.