Skip to content

Conversation

dterrahe
Copy link
Member

Simpler alternative to #19243

I believe this also fixes the infinite refresh loop you got because dt_dev_pixelpipe_process would store a transformed location and dt_view_paint_surface would compare it to the untransformed one it requested and immediately rerequest it.

Also dedupped (most of) _dev_distort_back/transform_locked

@ralfbrown
Copy link
Collaborator

Looks good on a quick skim (better than my proposal). The new tag should have a different name though - I propose either IOP_TAG_GEOMETRY or IOP_TAG_NODISTORT. Iops with the new tag aren't disabling the geometry-only transform, they can be viewed as either enabling it or disabling the full distortion transform.

@TurboGit TurboGit added this to the 5.4 milestone Aug 31, 2025
@TurboGit TurboGit added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: performance doing everything the same but faster labels Aug 31, 2025
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, a minor comment about naming of new enum.

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit 69d56a8 into darktable-org:master Sep 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: performance doing everything the same but faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants