[messages] Rename LinterLintCode.internal

Removes the deprecated `LinterLintCode` constructor, and renames
`LinterLintCode.internal` to `LinterLintCode`.

In https://dart-review.googlesource.com/c/sdk/+/459140,
`LinterLintCode` was renamed to `LinterLintCode.internal`, but the old
`LinterLintCode` constructor was left around because there were still
some references to it in google3. This allowed the signature of
`LinterLintCode.internal` to be evolved without introducing breakages.

Now that google3 code no longer uses the `LinterLintCode` constructor,
we can remove it and rename `LinterLintCode.internal` back to
`LinterLintCode`.

Change-Id: I6a6a6964bb9cd5d129612446cd1f035cd0f6a75e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/459201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>

Author: stereotype441

pkg/linter/lib/src/lint_codes.g.dart

@@ -2659,7 +2659,7 @@ class LinterLintCode extends LintCodeWithExpectedTypes {
   /// A lint code that removed lints can specify as their `lintCode`.
   ///
   /// Avoid other usages as it should be made unnecessary and removed.
-  static const LintCode removedLint = LinterLintCode.internal(
+  static const LintCode removedLint = LinterLintCode(
     name: 'removed_lint',
     problemMessage: 'Removed lint.',
     expectedTypes: [],
@@ -3740,21 +3740,7 @@ class LinterLintCode extends LintCodeWithExpectedTypes {
         expectedTypes: [],
       );
 
-  @Deprecated('Please use LintCode instead')
-  const LinterLintCode(
-    String name,
-    String problemMessage, {
-    super.expectedTypes,
-    super.correctionMessage,
-    super.hasPublishedDocs,
-    String? uniqueName,
-  }) : super(
-         name: name,
-         problemMessage: problemMessage,
-         uniqueName: 'LintCode.${uniqueName ?? name}',
-       );
-
-  const LinterLintCode.internal({
+  const LinterLintCode({
     required super.name,
     required super.problemMessage,
     required super.uniqueName,
@@ -4419,7 +4405,7 @@ final class LinterLintTemplate<T extends Function> extends LinterLintCode
     required super.uniqueName,
     super.correctionMessage,
     super.hasPublishedDocs = false,
-  }) : super.internal();
+  });
 }
 
 final class LinterLintWithoutArguments extends LinterLintCode
@@ -4432,5 +4418,5 @@ final class LinterLintWithoutArguments extends LinterLintCode
     required super.uniqueName,
     super.correctionMessage,
     super.hasPublishedDocs = false,
-  }) : super.internal();
+  });
 }

pkg/linter/test/lint_code_test.dart

@@ -27,15 +27,15 @@ void main() {
   });
 }
 
-const LintCode _customCode = LinterLintCode.internal(
+const LintCode _customCode = LinterLintCode(
   name: 'hash_and_equals',
   problemMessage: 'Override `==` if overriding `hashCode`.',
   correctionMessage: 'Implement `==`.',
   expectedTypes: [],
   uniqueName: 'LintCode.hash_and_equals',
 );
 
-const LintCode _customCodeWithDocs = LinterLintCode.internal(
+const LintCode _customCodeWithDocs = LinterLintCode(
   name: 'hash_and_equals',
   problemMessage: 'Override `==` if overriding `hashCode`.',
   correctionMessage: 'Implement `==`.',

pkg/linter/tool/generate_lints.dart

@@ -63,7 +63,7 @@ class LinterLintCode extends LintCodeWithExpectedTypes {
   /// A lint code that removed lints can specify as their `lintCode`.
   ///
   /// Avoid other usages as it should be made unnecessary and removed.
-  static const LintCode $removedLintName = LinterLintCode.internal(
+  static const LintCode $removedLintName = LinterLintCode(
     name: 'removed_lint',
     problemMessage: 'Removed lint.',
     expectedTypes: [],
@@ -72,23 +72,7 @@ class LinterLintCode extends LintCodeWithExpectedTypes {
 ''';
 
       memberAccumulator.constructors[''] = '''
-  @Deprecated('Please use LintCode instead')
-  const LinterLintCode(
-    String name,
-    String problemMessage, {
-    super.expectedTypes,
-    super.correctionMessage,
-    super.hasPublishedDocs,
-    String? uniqueName,
-  }) : super(
-    name: name,
-    problemMessage: problemMessage,
-    uniqueName: 'LintCode.\${uniqueName ?? name}',
-  );
-''';
-
-      memberAccumulator.constructors['internal'] = '''
-  const LinterLintCode.internal({
+  const LinterLintCode({
     required super.name,
     required super.problemMessage,
     required super.uniqueName,
@@ -126,7 +110,7 @@ final class LinterLintTemplate<T extends Function> extends LinterLintCode
     required super.uniqueName,
     super.correctionMessage,
     super.hasPublishedDocs = false,
-  }) : super.internal();
+  });
 }
 
 final class LinterLintWithoutArguments extends LinterLintCode
@@ -139,7 +123,7 @@ final class LinterLintWithoutArguments extends LinterLintCode
     required super.uniqueName,
     super.correctionMessage,
     super.hasPublishedDocs = false,
-  }) : super.internal();
+  });
 }
 ''');
       return out.toString();