[analysis_server] Remove support for macro virtual files / DartTextDocumentContentProvider

This removes all code related to handling requests for (and sending notifications of modifications of) the virtual files for macros.

Clients would never call this handler unless the analysis server had previously told them about these virtual files with the `dart-macro+file` scheme, which never happens because the implementation was previously removed.

This does not remove the `clientUriConverter` (which as well as handling conversions to/from the macro scheme, also handles conversions between URIs and Paths to support using URIs in the legacy protocol) because I'm not yet certain that is unused.

Change-Id: I148e2383a48b5f6e3a28eff3dd11506fc86353b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/461120
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>

Author: DanTup

pkg/analysis_server/integration_test/lsp/abstract_lsp_over_legacy.dart

@@ -22,7 +22,6 @@ abstract class AbstractLspOverLegacyTest
         ClientCapabilitiesHelperMixin,
         LspRequestHelpersMixin,
         LspReverseRequestHelpersMixin,
-        LspNotificationHelpersMixin,
         LspEditHelpersMixin,
         LspVerifyEditHelpersMixin {
   late final testFile = sourcePath('lib/main.dart');
@@ -37,7 +36,6 @@ abstract class AbstractLspOverLegacyTest
   final _overlayContent = <String, String>{};
 
   /// A stream of LSP [NotificationMessage]s from the server.
-  @override
   Stream<NotificationMessage> get notificationsFromServer =>
       onLspNotification.map(
         (params) => NotificationMessage.fromJson(

pkg/analysis_server/integration_test/lsp_server/integration_tests.dart

@@ -26,7 +26,6 @@ abstract class AbstractLspAnalysisServerIntegrationTest
         ClientCapabilitiesHelperMixin,
         LspRequestHelpersMixin,
         LspReverseRequestHelpersMixin,
-        LspNotificationHelpersMixin,
         LspEditHelpersMixin,
         LspVerifyEditHelpersMixin,
         LspAnalysisServerTestMixin {

pkg/analysis_server/lib/src/analysis_server.dart

@@ -1246,23 +1246,6 @@ abstract class CommonServerContextManagerCallbacks
     var path = result.path;
     filesToFlush.add(path);
 
-    // If this is a virtual file and the client supports URIs, we need to notify
-    // that it's been updated.
-    var lspUri = analysisServer.uriConverter.toClientUri(result.path);
-    if (!lspUri.isScheme('file')) {
-      // TODO(dantup): Should we do any kind of tracking here to avoid sending
-      //  lots of notifications if there aren't actual changes?
-      // TODO(dantup): We may be able to skip sending this if the file is not
-      //  open (priority) depending on the response to
-      //  https://github.com/microsoft/vscode/issues/202017
-      var message = lsp.NotificationMessage(
-        method: lsp.CustomMethods.dartTextDocumentContentDidChange,
-        params: lsp.DartTextDocumentContentDidChangeParams(uri: lspUri),
-        jsonrpc: lsp.jsonRpcVersion,
-      );
-      analysisServer.sendLspNotification(message);
-    }
-
     if (result is AnalysisResultWithDiagnostics) {
       if (analysisServer.isAnalyzed(path)) {
         var serverErrors = server.doAnalysisError_listFromEngine(result);

pkg/analysis_server/lib/src/legacy_analysis_server.dart

@@ -482,6 +482,9 @@ class LegacyAnalysisServer extends AnalysisServer {
   set clientCapabilities(ServerSetClientCapabilitiesParams capabilities) {
     _clientCapabilities = capabilities;
 
+    // TODO(dantup): If we can confirm that IntelliJ did not ship code that
+    //  sets supportsUris=true, then we may be able to entirely remove the
+    //  uriConverter and all the calls through it.
     if (capabilities.supportsUris ?? false) {
       // URI support implies LSP, as that's the only way to access (and get
       // change notifications for) custom-scheme files.

pkg/analysis_server/lib/src/lsp/client_capabilities.dart

@@ -4,26 +4,6 @@
 
 import 'package:analysis_server/lsp_protocol/protocol.dart';
 
-/// The key in the client capabilities experimental object that enables the Dart
-/// TextDocumentContentProvider.
-///
-/// The presence of this key indicates that the client supports our
-/// (non-standard) way of using TextDocumentContentProvider. This will need to
-/// continue to be supported after switching to standard LSP support for some
-/// period to support outdated extensions.
-const dartExperimentalTextDocumentContentProviderKey =
-    'supportsDartTextDocumentContentProvider';
-
-/// The original key used for [dartExperimentalTextDocumentContentProviderKey].
-///
-/// This is temporarily supported to avoid the macro support vanishing for users
-/// for a period if their SDK is updated before Dart-Code passes the standard
-/// flag.
-///
-const dartExperimentalTextDocumentContentProviderLegacyKey =
-    // TODO(dantup): Remove this after the next beta branch.
-    'supportsDartTextDocumentContentProviderEXP1';
-
 /// A fixed set of ClientCapabilities used for clients that may execute LSP
 /// requests without performing standard LSP initialization (such as a DTD
 /// client or LSP-over-Legacy).
@@ -127,11 +107,6 @@ class LspClientCapabilities {
   final Set<String> codeActionCommandParameterSupportedKinds;
   final bool supportsShowMessageRequest;
 
-  /// Whether the client supports the custom Dart TextDocumentContentProvider,
-  /// meaning it can request file contents from the server for custom URI
-  /// schemes.
-  final bool supportsDartExperimentalTextDocumentContentProvider;
-
   /// A set of commands that exist on the client that the server may call.
   final Set<String> supportedCommands;
 
@@ -251,8 +226,6 @@ class LspClientCapabilities {
       codeActionCommandParameterSupportedKinds:
           experimental.commandParameterKinds,
       supportsShowMessageRequest: experimental.showMessageRequest,
-      supportsDartExperimentalTextDocumentContentProvider:
-          experimental.dartTextDocumentContentProvider,
       supportedCommands: experimental.commands,
       experimentalCapabilitiesErrors: experimental.errors,
     );
@@ -293,7 +266,6 @@ class LspClientCapabilities {
     required this.experimentalSnippetTextEdit,
     required this.codeActionCommandParameterSupportedKinds,
     required this.supportsShowMessageRequest,
-    required this.supportsDartExperimentalTextDocumentContentProvider,
     required this.supportedCommands,
     required this.experimentalCapabilitiesErrors,
   });
@@ -319,14 +291,12 @@ class _ExperimentalClientCapabilities {
 
   final bool snippetTextEdit;
   final Set<String> commandParameterKinds;
-  final bool dartTextDocumentContentProvider;
   final Set<String> commands;
   final bool showMessageRequest;
 
   _ExperimentalClientCapabilities({
     required this.snippetTextEdit,
     required this.commandParameterKinds,
-    required this.dartTextDocumentContentProvider,
     required this.commands,
     required this.showMessageRequest,
     required this.errors,
@@ -392,15 +362,6 @@ class _ExperimentalClientCapabilities {
       commandParameters['supportedKinds'],
     );
 
-    // Macro/Augmentation content.
-    var dartContentValue =
-        experimental[dartExperimentalTextDocumentContentProviderKey] ??
-        experimental[dartExperimentalTextDocumentContentProviderLegacyKey];
-    var dartTextDocumentContentProvider = expectBool(
-      '.$dartExperimentalTextDocumentContentProviderKey',
-      dartContentValue,
-    );
-
     // Executable commands.
     var commands = expectNullableStringSet(
       '.commands',
@@ -423,7 +384,6 @@ class _ExperimentalClientCapabilities {
     return _ExperimentalClientCapabilities(
       snippetTextEdit: snippetTextEdit ?? false,
       commandParameterKinds: commandParameterKinds ?? {},
-      dartTextDocumentContentProvider: dartTextDocumentContentProvider ?? false,
       commands: commands ?? {},
       showMessageRequest: showMessageRequest ?? false,
       errors: errors,

pkg/analysis_server/lib/src/lsp/constants.dart

@@ -152,10 +152,6 @@ abstract final class CustomMethods {
   static const summary = Method('dart/textDocument/summary');
   static const super_ = Method('dart/textDocument/super');
   static const imports = Method('dart/textDocument/imports');
-  static const dartTextDocumentContent = Method('dart/textDocumentContent');
-  static const dartTextDocumentContentDidChange = Method(
-    'dart/textDocumentContentDidChange',
-  );
 
   /// Method for requesting the set of editable arguments at a location in a
   /// document.

pkg/analysis_server/lib/src/lsp/handlers/custom/handler_dart_text_document_content_provider.dart

@@ -13,7 +13,6 @@ import 'package:analysis_server/src/lsp/handlers/custom/editable_arguments/handl
 import 'package:analysis_server/src/lsp/handlers/custom/handler_augmentation.dart';
 import 'package:analysis_server/src/lsp/handlers/custom/handler_augmented.dart';
 import 'package:analysis_server/src/lsp/handlers/custom/handler_connect_to_dtd.dart';
-import 'package:analysis_server/src/lsp/handlers/custom/handler_dart_text_document_content_provider.dart';
 import 'package:analysis_server/src/lsp/handlers/custom/handler_diagnostic_server.dart';
 import 'package:analysis_server/src/lsp/handlers/custom/handler_experimental_echo.dart';
 import 'package:analysis_server/src/lsp/handlers/custom/handler_imports.dart';
@@ -126,7 +125,6 @@ class InitializedStateMessageHandler extends ServerStateMessageHandler {
         CodeActionHandler.new,
         CodeLensHandler.new,
         ConnectToDtdHandler.new,
-        DartTextDocumentContentProviderHandler.new,
         DocumentColorHandler.new,
         DocumentColorPresentationHandler.new,
         DocumentHighlightsHandler.new,

pkg/analysis_server/lib/src/lsp/handlers/handler_states.dart

@@ -47,7 +47,6 @@ import 'package:analyzer/src/utilities/extensions/flutter.dart';
 import 'package:analyzer_plugin/protocol/protocol_common.dart' as plugin;
 import 'package:analyzer_plugin/protocol/protocol_generated.dart' as plugin;
 import 'package:analyzer_plugin/src/protocol/protocol_internal.dart' as plugin;
-import 'package:analyzer_plugin/src/utilities/client_uri_converter.dart';
 import 'package:http/http.dart' as http;
 import 'package:meta/meta.dart';
 
@@ -398,15 +397,6 @@ class LspAnalysisServer extends AnalysisServer {
     var initializationOptions = _initializationOptions =
         LspInitializationOptions(rawInitializationOptions);
 
-    /// Enable virtual file support.
-    var supportsVirtualFiles =
-        _clientCapabilities
-            ?.supportsDartExperimentalTextDocumentContentProvider ??
-        false;
-    if (supportsVirtualFiles) {
-      uriConverter = ClientUriConverter.withVirtualFileSupport(pathContext);
-    }
-
     // Set whether to allow interleaved requests.
     if (initializationOptions.allowOverlappingHandlers
         case var allowOverlappingHandlers?) {

pkg/analysis_server/lib/src/lsp/lsp_analysis_server.dart

@@ -5,7 +5,6 @@
 import 'package:analysis_server/lsp_protocol/protocol.dart';
 import 'package:analysis_server/src/lsp/client_capabilities.dart';
 import 'package:analysis_server/src/lsp/client_configuration.dart';
-import 'package:analysis_server/src/lsp/handlers/custom/handler_dart_text_document_content_provider.dart';
 import 'package:analysis_server/src/lsp/handlers/handler_call_hierarchy.dart';
 import 'package:analysis_server/src/lsp/handlers/handler_change_workspace_folders.dart';
 import 'package:analysis_server/src/lsp/handlers/handler_code_actions.dart';
@@ -114,8 +113,6 @@ class LspFeatures {
   final WorkspaceDidChangeConfigurationRegistrations
   workspaceDidChangeConfiguration;
   final WorkspaceSymbolRegistrations workspaceSymbol;
-  final DartTextDocumentContentProviderRegistrations
-  dartTextDocumentContentProvider;
 
   LspFeatures(RegistrationContext context)
     : callHierarchy = CallHierarchyRegistrations(context),
@@ -148,9 +145,7 @@ class LspFeatures {
       willRename = WillRenameFilesRegistrations(context),
       workspaceDidChangeConfiguration =
           WorkspaceDidChangeConfigurationRegistrations(context),
-      workspaceSymbol = WorkspaceSymbolRegistrations(context),
-      dartTextDocumentContentProvider =
-          DartTextDocumentContentProviderRegistrations(context);
+      workspaceSymbol = WorkspaceSymbolRegistrations(context);
 
   List<FeatureRegistration> get allFeatures => [
     callHierarchy,