DAS: rename constants to use lowerCamelCase

Change-Id: If3f23ffc275171c67d0dc9cab3ee4abb7c5bc117
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/461181
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>

Author: srawlins

pkg/analysis_server/integration_test/support/integration_tests.dart

@@ -110,7 +110,7 @@ abstract class AbstractAnalysisServerIntegrationTest extends IntegrationTest
     with MockPackagesMixin, ConfigurationFilesMixin {
   /// Amount of time to give the server to respond to a shutdown request before
   /// forcibly terminating it.
-  static const Duration SHUTDOWN_TIMEOUT = Duration(seconds: 60);
+  static const Duration shutdownTimeout = Duration(seconds: 60);
 
   /// Connection to the analysis server.
   @override
@@ -287,7 +287,7 @@ abstract class AbstractAnalysisServerIntegrationTest extends IntegrationTest
     // doesn't exit, then forcibly terminate it.
     sendServerShutdown();
     return server.exitCode.timeout(
-      SHUTDOWN_TIMEOUT,
+      shutdownTimeout,
       onTimeout: () {
         // The integer value of the exit code isn't used, but we have to return
         // an integer to keep the typing correct.

pkg/analysis_server/lib/src/analysis_server.dart

@@ -572,12 +572,12 @@ abstract class AnalysisServer {
     bool registerExperimentalHandlers = false,
   }) async {
     switch (dtd?.state) {
-      case DtdConnectionState.Connecting || DtdConnectionState.Connected:
+      case DtdConnectionState.connecting || DtdConnectionState.connected:
         return lsp.error(
           lsp.ServerErrorCodes.stateError,
           'Server is already connected to DTD',
         );
-      case DtdConnectionState.Disconnected || DtdConnectionState.Error || null:
+      case DtdConnectionState.disconnected || DtdConnectionState.error || null:
         var connectResult = await DtdServices.connect(
           this,
           dtdUri,

pkg/analysis_server/lib/src/plugin/plugin_isolate.dart

@@ -239,11 +239,11 @@ class PluginIsolate {
 class PluginSession {
   /// The maximum number of milliseconds that server should wait for a response
   /// from a plugin before deciding that the plugin is hung.
-  static const Duration MAXIMUM_RESPONSE_TIME = Duration(minutes: 2);
+  static const Duration _maximumResponseTime = Duration(minutes: 2);
 
   /// The length of time to wait after sending a 'plugin.shutdown' request
   /// before a failure to terminate will cause the isolate to be killed.
-  static const Duration WAIT_FOR_SHUTDOWN_DURATION = Duration(seconds: 10);
+  static const Duration _waitForShutdownDuration = Duration(seconds: 10);
 
   /// The information about the plugin being executed.
   final PluginIsolate _isolate;
@@ -349,7 +349,7 @@ class PluginSession {
     // identify non-responsive plugins and kill them.
     var cutOffTime =
         DateTime.now().millisecondsSinceEpoch -
-        MAXIMUM_RESPONSE_TIME.inMilliseconds;
+        _maximumResponseTime.inMilliseconds;
     for (var requestData in pendingRequests.values) {
       if (requestData.requestTime < cutOffTime) {
         return true;
@@ -476,7 +476,7 @@ class PluginSession {
       throw StateError('Cannot stop a plugin that is not running.');
     }
     sendRequest(PluginShutdownParams());
-    Future.delayed(WAIT_FOR_SHUTDOWN_DURATION, () {
+    Future.delayed(_waitForShutdownDuration, () {
       if (channel != null) {
         channel?.kill();
         channel = null;

pkg/analysis_server/lib/src/server/http_server.dart

@@ -27,7 +27,7 @@ abstract class AbstractHttpHandler {
 /// - serves diagnostic information as html pages
 class HttpAnalysisServer {
   /// Number of lines of print output to capture.
-  static const int MAX_PRINT_BUFFER_LENGTH = 1000;
+  static const int _maxPrintBufferLength = 1000;
 
   /// An object that can handle either a WebSocket connection or a connection
   /// to the client over stdio.
@@ -62,11 +62,8 @@ class HttpAnalysisServer {
   /// Record that the given line was printed out by the analysis server.
   void recordPrint(String line) {
     _printBuffer.add(line);
-    if (_printBuffer.length > MAX_PRINT_BUFFER_LENGTH) {
-      _printBuffer.removeRange(
-        0,
-        _printBuffer.length - MAX_PRINT_BUFFER_LENGTH,
-      );
+    if (_printBuffer.length > _maxPrintBufferLength) {
+      _printBuffer.removeRange(0, _printBuffer.length - _maxPrintBufferLength);
     }
   }
 

pkg/analysis_server/lib/src/services/completion/dart/utilities.dart

@@ -20,7 +20,7 @@ import 'package:analyzer_plugin/protocol/protocol_common.dart'
     show Element, ElementKind;
 
 /// The name of the type `dynamic`;
-const DYNAMIC = 'dynamic';
+const _dynamicName = 'dynamic';
 
 /// Sort by relevance first, highest to lowest, and then by the completion
 /// alphabetically.
@@ -249,7 +249,7 @@ String? nameForType(SimpleIdentifier identifier, TypeAnnotation? declaredType) {
   DartType type;
   var element = identifier.element;
   if (element == null) {
-    return DYNAMIC;
+    return _dynamicName;
   } else if (element is FunctionTypedElement) {
     if (element is PropertyAccessorElement && element is SetterElement) {
       return null;
@@ -273,7 +273,7 @@ String? nameForType(SimpleIdentifier identifier, TypeAnnotation? declaredType) {
     if (declaredType is NamedType) {
       return declaredType.qualifiedName;
     }
-    return DYNAMIC;
+    return _dynamicName;
   }
   return type.getDisplayString();
 }

pkg/analysis_server/lib/src/services/correction/fix/pubspec/fix_kind.dart

@@ -8,16 +8,16 @@ import 'package:analyzer_plugin/utilities/fixes/fixes.dart';
 abstract final class PubspecFixKind {
   static const addName = FixKind(
     'pubspec.fix.add.name',
-    PubspecFixKindPriority.DEFAULT,
+    PubspecFixKindPriority._default,
     "Add 'name' key",
   );
   static const addDependency = FixKind(
     'pubspec.fix.add.dependency',
-    PubspecFixKindPriority.DEFAULT,
+    PubspecFixKindPriority._default,
     'Update pubspec with the missing dependencies',
   );
 }
 
 abstract final class PubspecFixKindPriority {
-  static const int DEFAULT = 50;
+  static const int _default = 50;
 }

pkg/analysis_server/lib/src/services/dart_tooling_daemon/dtd_services.dart

@@ -21,16 +21,16 @@ import 'package:json_rpc_2/json_rpc_2.dart';
 /// The state of the connection to DTD.
 enum DtdConnectionState {
   /// A connection is being made or initialization is in progress.
-  Connecting,
+  connecting,
 
   /// The connection is available to use.
-  Connected,
+  connected,
 
   /// The connection is closing or closed.
-  Disconnected,
+  disconnected,
 
   /// A fatal error occurred setting up the connection to DTD.
-  Error,
+  error,
 }
 
 /// A connection to DTD that exposes some analysis services (such as a subset
@@ -49,7 +49,7 @@ class DtdServices {
   /// A raw connection to the Dart Tooling Daemon.
   DartToolingDaemon? _dtd;
 
-  DtdConnectionState _state = DtdConnectionState.Connecting;
+  DtdConnectionState _state = DtdConnectionState.connecting;
 
   /// Whether to register experimental LSP handlers over DTD.
   final bool registerExperimentalHandlers;
@@ -110,7 +110,7 @@ class DtdServices {
   }
 
   /// Closes the connection to DTD and cleans up.
-  void _close([DtdConnectionState state = DtdConnectionState.Disconnected]) {
+  void _close([DtdConnectionState state = DtdConnectionState.disconnected]) {
     _state = state;
 
     // This code may have been closed because the connection closed, or it might
@@ -206,7 +206,7 @@ class DtdServices {
       ['Failed to connect to/initialize DTD:', error, ?stack].join('\n'),
     );
 
-    _close(DtdConnectionState.Error);
+    _close(DtdConnectionState.error);
   }
 
   /// Registers any request handlers provided by the server handler [handler]

pkg/analysis_server/lib/src/services/refactoring/legacy/extract_local.dart

@@ -27,7 +27,7 @@ import 'package:analyzer/src/generated/java_core.dart';
 import 'package:analyzer/src/utilities/dot_shorthands.dart';
 import 'package:analyzer_plugin/utilities/range_factory.dart';
 
-const String _TOKEN_SEPARATOR = '\uFFFF';
+const String _tokenSeparator = '\uFFFF';
 
 /// [ExtractLocalRefactoring] implementation.
 class ExtractLocalRefactoringImpl extends RefactoringImpl
@@ -440,8 +440,8 @@ class ExtractLocalRefactoringImpl extends RefactoringImpl
           // done
           return tokenString;
         })
-        .join(_TOKEN_SEPARATOR);
-    return result + _TOKEN_SEPARATOR;
+        .join(_tokenSeparator);
+    return result + _tokenSeparator;
   }
 
   /// Return the [AstNode] to defined the variable before.

pkg/analysis_server/lib/src/services/refactoring/legacy/naming_conventions.dart

@@ -179,8 +179,7 @@ RefactoringStatus _validateIdentifier(
   // invalid characters
   for (var i = 0; i < length; i++) {
     var currentChar = identifier.codeUnitAt(i);
-    if (!currentChar.isLetterOrDigitOrUnderscore &&
-        currentChar != CHAR_DOLLAR) {
+    if (!currentChar.isLetterOrDigitOrUnderscore && currentChar != charDollar) {
       var charStr = String.fromCharCode(currentChar);
       var message = "$desc must not contain '$charStr'.";
       return RefactoringStatus.fatal(message);
@@ -189,8 +188,8 @@ RefactoringStatus _validateIdentifier(
   // first character
   var currentChar = identifier.codeUnitAt(0);
   if (!currentChar.isLetter &&
-      currentChar != CHAR_UNDERSCORE &&
-      currentChar != CHAR_DOLLAR) {
+      currentChar != charUnderscore &&
+      currentChar != charDollar) {
     var message = '$desc must begin with $beginDesc.';
     return RefactoringStatus.fatal(message);
   }
@@ -216,11 +215,11 @@ RefactoringStatus _validateLowerCamelCase(
     return status;
   }
   // is private, OK
-  if (identifier.codeUnitAt(0) == CHAR_UNDERSCORE) {
+  if (identifier.codeUnitAt(0) == charUnderscore) {
     return RefactoringStatus();
   }
   // leading $, OK
-  if (identifier.codeUnitAt(0) == CHAR_DOLLAR) {
+  if (identifier.codeUnitAt(0) == charDollar) {
     return RefactoringStatus();
   }
   // does not start with lower case
@@ -245,11 +244,11 @@ RefactoringStatus _validateUpperCamelCase(String identifier, String desc) {
     return status;
   }
   // is private, OK
-  if (identifier.codeUnitAt(0) == CHAR_UNDERSCORE) {
+  if (identifier.codeUnitAt(0) == charUnderscore) {
     return RefactoringStatus();
   }
   // leading $, OK
-  if (identifier.codeUnitAt(0) == CHAR_DOLLAR) {
+  if (identifier.codeUnitAt(0) == charDollar) {
     return RefactoringStatus();
   }
   // does not start with upper case

pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring_manager.dart

@@ -40,7 +40,7 @@ bool test_simulateRefactoringReset_afterInitialConditions = false;
 /// Once new set of parameters is received, the previous [Refactoring] instance
 /// is invalidated and a new one is created and initialized.
 class RefactoringManager {
-  static const List<RefactoringProblem> EMPTY_PROBLEM_LIST =
+  static const List<RefactoringProblem> _emptyProblemList =
       <RefactoringProblem>[];
 
   final LegacyAnalysisServer server;
@@ -104,9 +104,9 @@ class RefactoringManager {
     // prepare for processing the request
     this.request = request;
     var result = this.result = EditGetRefactoringResult(
-      EMPTY_PROBLEM_LIST,
-      EMPTY_PROBLEM_LIST,
-      EMPTY_PROBLEM_LIST,
+      _emptyProblemList,
+      _emptyProblemList,
+      _emptyProblemList,
     );
 
     // process the request