-
Notifications
You must be signed in to change notification settings - Fork 742
feat: Add tooltips to glossary term links with their definition #6969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Visit the preview URL for this PR (updated for commit 837fab7): https://dart-dev--pr6969-feat-glossary-tooltip-aq2t2rdr.web.app |
|
I love the functionality @schultek! Thanks :D What about keyboard only users though? Would it make sense to also show the tooltip if the link is focused? |
|
Good catch, I will add focus support as well |
594b3eb to
35fbc1d
Compare
|
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super exciting. Thanks for working on this @schultek!
Works super well! I just have some small suggestions and questions.
6f5382e to
7b112cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those adjustments @schultek! Looks good to me after some small suggestions:
|
@parlough all done |
0e2732c to
bbcd9bc
Compare
|
@schultek This still looks good to me, but before we land it, can you investigate a pre-existing issue? It seems navigating to the full glossary terms scrolls to the wrong section of the page (which is a bit confusing from the learn more links). Without looking, I'm guessing because they are being closed on load and the location of the fragment is changing? |
Fixed |
|
Thanks for making that adjustment! Everything looks great :D |
Shows a tooltip for all glossary links with their term and definition. Glossary links are styled differently than normal links to give a visual indication to the visitor.
Always positions the tooltip inside the content container with no horizontal overflow.