Skip to content

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jan 31, 2025

  • Add DART_USE_SYSTEM_TRACY option
  • Remove Docker for Tracy in favor of conda-forge::tracy-profiler-gui (run pixi run tracy)
  • Upgrade pybind11 to v2.13.6
  • Remove use of TRUE and FALSE in enum to avoid conflict with global macros (on macOS and Windows)

Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 added this to the DART 6.16.0 milestone Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.55%. Comparing base (3142070) to head (86625e4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1911   +/-   ##
=======================================
  Coverage   61.55%   61.55%           
=======================================
  Files         490      490           
  Lines       46013    46013           
=======================================
  Hits        28322    28322           
  Misses      17691    17691           
Files with missing lines Coverage Δ
dart/simulation/World.cpp 70.09% <ø> (ø)
dart/utils/mjcf/detail/Compiler.cpp 48.30% <ø> (ø)
dart/utils/mjcf/detail/Compiler.hpp 100.00% <ø> (ø)

@jslee02 jslee02 merged commit 4d74bf9 into main Jan 31, 2025
33 of 36 checks passed
@jslee02 jslee02 deleted the tracy_profiler branch January 31, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant