Skip to content

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 18, 2025

Summary

  • update pixi.toml config task so CMake installs with an RPATH

Testing

  • pixi run build-tests (fails: pixi command not found)
  • pixi run test (fails: pixi command not found)

@jslee02 jslee02 force-pushed the codex/update-cmake-command-for-install-rpath branch from 7196feb to 51929ef Compare May 18, 2025 03:13
@jslee02 jslee02 requested a review from Copilot May 18, 2025 03:13
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Pixi CMake configuration in pixi.toml to install with an RPATH.

  • Enables CMAKE_BUILD_WITH_INSTALL_RPATH=ON
  • Sets CMAKE_INSTALL_RPATH to the Conda lib directory
  • Moves CMAKE_INSTALL_PREFIX to group all install-related flags
Comments suppressed due to low confidence (3)

pixi.toml:55

  • [nitpick] Consider adding a comment explaining why CMAKE_BUILD_WITH_INSTALL_RPATH is enabled, so future readers understand its purpose in the Conda-based install.
-        -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON \

pixi.toml:57

  • [nitpick] Hardcoding $CONDA_PREFIX/lib can reduce portability; consider using a relative RPATH like $ORIGIN/../lib or enabling CMAKE_INSTALL_RPATH_USE_LINK_PATH to automatically include link paths.
-        -DCMAKE_INSTALL_RPATH=$CONDA_PREFIX/lib \

pixi.toml:55

  • Add a test or CI check to verify that installed binaries actually carry the intended RPATH, ensuring the new flags have the desired effect.
-        -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON \

@jslee02 jslee02 requested a review from Copilot May 18, 2025 03:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CMake invocation in the pixi.toml config to embed an install RPATH pointing at the Conda library directory.

  • Enables CMAKE_BUILD_WITH_INSTALL_RPATH so binaries carry the RPATH at build time
  • Sets CMAKE_INSTALL_RPATH to $CONDA_PREFIX/lib
  • Moves CMAKE_INSTALL_PREFIX to follow the RPATH flags for clarity
Comments suppressed due to low confidence (2)

pixi.toml:57

  • [nitpick] Embedding an absolute $CONDA_PREFIX/lib path can break relocatable installs; consider using a relative RPATH like $ORIGIN/../lib or enabling CMAKE_INSTALL_RPATH_USE_LINK_PATH=ON to automatically include linked library paths.
-        -DCMAKE_INSTALL_RPATH=$CONDA_PREFIX/lib \

pixi.toml:55

  • If you want CMake to propagate dependency paths into the install RPATH, you may also enable -DCMAKE_INSTALL_RPATH_USE_LINK_PATH=ON alongside CMAKE_BUILD_WITH_INSTALL_RPATH.
-        -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON \

@jslee02 jslee02 marked this pull request as ready for review May 18, 2025 03:26
@jslee02 jslee02 merged commit 987c962 into main May 18, 2025
4 of 25 checks passed
@jslee02 jslee02 deleted the codex/update-cmake-command-for-install-rpath branch May 18, 2025 03:26
jslee02 added a commit that referenced this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant