Skip to content

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 21, 2025

  • Track whether a VisualAspect color is unset vs explicit (usesDefaultColor/resetColor/getDefaultRGBA)
  • Treat textured meshes as neutral when the color is unset while still allowing explicit tinting and alpha control
  • Add unit coverage and register the new VisualAspect test

Fixes #739


Before creating a pull request

  • Run pixi run test-all to lint, build, and test your changes (CI runs covered)
  • Add unit tests for new functionality
  • Document new methods and classes
  • Add Python bindings (dartpy) if applicable

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.82%. Comparing base (a3390cd) to head (88d33be).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2230      +/-   ##
==========================================
+ Coverage   60.77%   60.82%   +0.04%     
==========================================
  Files         353      353              
  Lines       31866    31880      +14     
  Branches     4128     4129       +1     
==========================================
+ Hits        19368    19392      +24     
+ Misses      12498    12488      -10     
Flag Coverage Δ
unittests 60.82% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dart/dynamics/ShapeFrame.cpp 78.47% <100.00%> (+7.15%) ⬆️
dart/dynamics/ShapeFrame.hpp 75.00% <ø> (ø)
dart/dynamics/detail/ShapeFrameAspect.hpp 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 force-pushed the feature/visual-aspect-default-color branch from d0a4cb2 to d1fa38f Compare November 22, 2025 18:33
@jslee02 jslee02 added this to the DART 7.0 milestone Nov 23, 2025
@jslee02 jslee02 merged commit 848320a into main Nov 23, 2025
35 checks passed
@jslee02 jslee02 deleted the feature/visual-aspect-default-color branch November 23, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Distinguish between missing vs. default VisualAspect color

2 participants