Skip to content

Commit dad7ba9

Browse files
committed
PLUGIN-1883: Rename method
Rename method describeTable() to getFieldDescriptors()
1 parent 6d7a9b4 commit dad7ba9

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

src/main/java/io/cdap/plugin/snowflake/common/client/SnowflakeAccessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public void runSQL(String query) {
8282
* @return list of field descriptors
8383
* @throws SQLException If an error occurs while retrieving metadata from the database
8484
*/
85-
public List<SnowflakeFieldDescriptor> describeTable(String schemaName, String tableName) throws SQLException {
85+
public List<SnowflakeFieldDescriptor> getFieldDescriptors(String schemaName, String tableName) throws SQLException {
8686
List<SnowflakeFieldDescriptor> fieldDescriptors = new ArrayList<>();
8787
try (Connection connection = dataSource.getConnection()) {
8888
DatabaseMetaData dbMetaData = connection.getMetaData();

src/main/java/io/cdap/plugin/snowflake/common/util/SchemaHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ private static Schema getSchema(SnowflakeAccessor snowflakeAccessor, @Nullable S
125125
try {
126126
List<SnowflakeFieldDescriptor> result;
127127
if (!Strings.isNullOrEmpty(tableName)) {
128-
result = snowflakeAccessor.describeTable(snowflakeAccessor.getSchema(), tableName);
128+
result = snowflakeAccessor.getFieldDescriptors(snowflakeAccessor.getSchema(), tableName);
129129
} else if (!Strings.isNullOrEmpty(importQuery)) {
130130
result = snowflakeAccessor.describeQuery(importQuery);
131131
} else {

src/test/java/io/cdap/plugin/snowflake/common/client/SnowflakeAccessorTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,9 @@ public void testDescribeTable() throws Exception {
117117
new SnowflakeFieldDescriptor("COLUMN_ARRAY", 12, true)
118118
);
119119

120-
List<SnowflakeFieldDescriptor> actual = snowflakeAccessor.describeTable(String.valueOf(Constants.TEST_TABLE_SCHEMA),
121-
Constants.TEST_TABLE);
120+
List<SnowflakeFieldDescriptor> actual = snowflakeAccessor.getFieldDescriptors(
121+
String.valueOf(Constants.TEST_TABLE_SCHEMA),
122+
Constants.TEST_TABLE);
122123

123124
Assert.assertNotNull(actual);
124125
Assert.assertFalse(actual.isEmpty());

src/test/java/io/cdap/plugin/snowflake/common/util/SchemaHelperTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public void testGetSchemaFromSnowflakeUnknownType() throws IOException, SQLExcep
7474
List<SnowflakeFieldDescriptor> sample = new ArrayList<>();
7575
sample.add(new SnowflakeFieldDescriptor("field1", -1000, false));
7676

77-
Mockito.when(snowflakeAccessor.describeTable(null, tableName)).thenReturn(sample);
77+
Mockito.when(snowflakeAccessor.getFieldDescriptors(null, tableName)).thenReturn(sample);
7878

7979
SchemaHelper.getSchema(snowflakeAccessor, null, collector, tableName, importQuery);
8080

@@ -148,7 +148,7 @@ public void testGetSchemaFromSnowflake() throws IOException, SQLException {
148148
);
149149

150150
Mockito.when(snowflakeAccessor.describeQuery(importQuery)).thenReturn(sample);
151-
Mockito.when(snowflakeAccessor.describeTable(Mockito.any(), Mockito.eq(tableName))).thenReturn(sample);
151+
Mockito.when(snowflakeAccessor.getFieldDescriptors(Mockito.any(), Mockito.eq(tableName))).thenReturn(sample);
152152

153153
Schema actual = SchemaHelper.getSchema(snowflakeAccessor, null, collector, tableName, importQuery);
154154

0 commit comments

Comments
 (0)