Skip to content

Commit 53417f0

Browse files
authored
chore(cli): refactor pretty sql (#551)
chore(cli): update pretty sql
1 parent 326578c commit 53417f0

File tree

2 files changed

+18
-6
lines changed

2 files changed

+18
-6
lines changed

cli/Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ async-trait = "0.1"
2424
clap = { version = "4.4", features = ["derive", "env"] }
2525
comfy-table = "7.1"
2626
csv = "1.3"
27-
databend-common-ast = "0.1.2"
27+
databend-common-ast = "0.1.3"
2828
fern = { version = "0.6", features = ["colored"] }
2929
indicatif = "0.17"
3030
log = "0.4"
@@ -36,6 +36,7 @@ rustyline = "12.0"
3636
serde = { version = "1.0", features = ["derive"] }
3737
serde_json = "1.0"
3838
sled = "0.34"
39+
sqlformat = "0.3.3"
3940
terminal_size = "0.3"
4041
tokio = { version = "1.34", features = [
4142
"macros",

cli/src/ast/mod.rs

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,8 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
use databend_common_ast::{
16-
ast::pretty_statement,
17-
parser::{parse_sql, token::TokenKind, tokenize_sql, Dialect},
18-
};
15+
use databend_common_ast::parser::{parse_sql, token::TokenKind, tokenize_sql, Dialect};
16+
use sqlformat::{FormatOptions, QueryParams};
1917

2018
use crate::session::QueryKind;
2119

@@ -24,9 +22,22 @@ pub fn format_query(query: &str) -> String {
2422
if kind == QueryKind::Put || kind == QueryKind::Get {
2523
return query.to_owned();
2624
}
25+
2726
if let Ok(tokens) = databend_common_ast::parser::tokenize_sql(query) {
2827
if let Ok((stmt, _)) = parse_sql(&tokens, Dialect::Experimental) {
29-
return pretty_statement(stmt, 80).unwrap();
28+
let options = FormatOptions::default();
29+
30+
let pretty_sql = sqlformat::format(query, &QueryParams::None, &options);
31+
// if pretty sql could be parsed into same stmt, return pretty sql
32+
if let Ok(pretty_tokens) = databend_common_ast::parser::tokenize_sql(&pretty_sql) {
33+
if let Ok((pretty_stmt, _)) = parse_sql(&pretty_tokens, Dialect::Experimental) {
34+
if stmt.to_string() == pretty_stmt.to_string() {
35+
return pretty_sql;
36+
}
37+
}
38+
}
39+
40+
return stmt.to_string();
3041
}
3142
}
3243
query.to_string()

0 commit comments

Comments
 (0)