Skip to content

fix: support ExecContext cancel query #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024
Merged

fix: support ExecContext cancel query #127

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87a56fd
fix: support ExecContext cancel query
hantmac Jun 13, 2024
fba9e70
fix
hantmac Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions restful.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,12 @@ func (c *APIClient) PollUntilQueryEnd(ctx context.Context, resp *QueryResponse)
data := resp.Data
resp, err = c.PollQuery(ctx, resp.NextURI)
if err != nil {
if errors.Is(err, context.Canceled) {
// context might be canceled due to timeout or canceled. if it's canceled, we need call
// the kill url to tell the backend it's killed.
fmt.Printf("query canceled, kill query:%s", resp.ID)
_ = c.KillQuery(context.Background(), resp)
}
return nil, err
}
if resp.Error != nil {
Expand Down