Skip to content

chore: use fmt.Errorf instead of errors.Wrap#146

Closed
flaneur2020 wants to merge 1 commit intodatabendlabs:mainfrom
flaneur2020:chore/tune-errors-wrap
Closed

chore: use fmt.Errorf instead of errors.Wrap#146
flaneur2020 wants to merge 1 commit intodatabendlabs:mainfrom
flaneur2020:chore/tune-errors-wrap

Conversation

@flaneur2020
Copy link
Contributor

it seems that errors.Wrap was introduced before fmt.Errorf() in the stdlib was introduced.

the current error message is like:

context canceled: DoRequestFailed

the convention is becoming to put the root cause part into the right side, for example:

do request failed: context canceled

@forsaken628
Copy link
Contributor

github.com/pkg/errors provides stack information that will make debugging easier, otherwise we need to carefully handle the error message

@hantmac hantmac closed this Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants