Merge pull request #325 from databendlabs/fix/insert-with-select

fix: insert with select case

Author: hantmac

databend-jdbc/src/main/java/com/databend/jdbc/DatabendPreparedStatement.java

@@ -532,8 +532,8 @@ public void setBigDecimal(int i, BigDecimal bigDecimal)
     public void setString(int i, String s)
             throws SQLException {
         checkOpen();
-        if (originalSql.toLowerCase().startsWith("insert") ||
-                originalSql.toLowerCase().startsWith("replace")) {
+        if ((originalSql.toLowerCase().startsWith("insert") ||
+                originalSql.toLowerCase().startsWith("replace")) && !originalSql.toLowerCase().contains("select"))  {
             String finalS1 = s;
             batchInsertUtils.ifPresent(insertUtils -> insertUtils.setPlaceHolderValue(i, finalS1));
         } else {

databend-jdbc/src/test/java/com/databend/jdbc/TestPrepareStatement.java

@@ -641,4 +641,47 @@ public void testExecuteUpdate() throws SQLException {
         conn.createStatement().execute("delete from test_prepare_statement");
     }
 
+    @Test
+
+    public void testInsertWithSelect() throws SQLException {
+        Connection conn = Utils.createConnection();
+        conn.createStatement().execute("delete from test_prepare_statement");
+
+        String insertSql = "insert into test_prepare_statement select a, b from test_prepare_statement where b = ?";
+        try (PreparedStatement statement = conn.prepareStatement(insertSql)) {
+            statement.setString(1, "a");
+            int insertedRows = statement.executeUpdate();
+            Assertions.assertEquals(0, insertedRows, "should not insert any rows as the table is empty");
+        }
+
+        // Insert some data
+        String insertDataSql = "insert into test_prepare_statement values (?,?)";
+        try (PreparedStatement statement = conn.prepareStatement(insertDataSql)) {
+            statement.setInt(1, 1);
+            statement.setString(2, "a");
+            statement.executeUpdate();
+
+            statement.setInt(1, 2);
+            statement.setString(2, "b");
+            statement.executeUpdate();
+        }
+
+        // Now try to insert again with select
+        try (PreparedStatement statement = conn.prepareStatement(insertSql)) {
+            statement.setString(1, "a");
+            int insertedRows = statement.executeUpdate();
+            Assertions.assertEquals(1, insertedRows, "should insert two rows from the select");
+        }
+
+        ResultSet rs = conn.createStatement().executeQuery("select * from test_prepare_statement order by a");
+        int count = 0;
+        while (rs.next()) {
+            count++;
+        }
+        Assertions.assertEquals(3, count, "should have four rows in the table after insert with select");
+
+        // Clean up
+        conn.createStatement().execute("delete from test_prepare_statement");
+    }
+
 }