Skip to content

Commit 7990f33

Browse files
authored
Merge pull request #9058 from drmingdrmer/50-tracker
chore(mem-tracker): rename tracker related terms to reflect their actual usage
2 parents 00204fe + 66c1afd commit 7990f33

File tree

12 files changed

+158
-163
lines changed

12 files changed

+158
-163
lines changed

src/binaries/query/main.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
use std::env;
1616

1717
use common_base::base::Runtime;
18-
use common_base::base::GLOBAL_TRACKER;
18+
use common_base::base::GLOBAL_MEM_STAT;
1919
use common_config::Config;
2020
use common_config::DATABEND_COMMIT_VERSION;
2121
use common_config::QUERY_SEMVER;
@@ -70,7 +70,7 @@ async fn main_entrypoint() -> Result<()> {
7070
if conf.query.max_memory_limit_enabled {
7171
let size = conf.query.max_server_memory_usage as i64;
7272
info!("Set memory limit: {}", size);
73-
GLOBAL_TRACKER.set_limit(size);
73+
GLOBAL_MEM_STAT.set_limit(size);
7474
}
7575

7676
let tenant = conf.query.tenant_id.clone();

src/common/base/src/base/mod.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ pub use progress::ProgressValues;
3939
pub use runtime::Dropper;
4040
pub use runtime::Runtime;
4141
pub use runtime::TrySpawn;
42-
pub use runtime_tracker::AsyncThreadTracker;
43-
pub use runtime_tracker::MemoryTracker;
42+
pub use runtime_tracker::MemStat;
4443
pub use runtime_tracker::ThreadTracker;
45-
pub use runtime_tracker::GLOBAL_TRACKER;
44+
pub use runtime_tracker::TrackedFuture;
45+
pub use runtime_tracker::GLOBAL_MEM_STAT;
4646
pub use select::select3;
4747
pub use select::Select3Output;
4848
pub use shutdown_signal::signal_stream;

src/common/base/src/base/runtime.rs

+12-16
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ use tokio::sync::Semaphore;
2929
use tokio::task::JoinHandle;
3030

3131
use crate::base::catch_unwind::CatchUnwindFuture;
32-
use crate::base::runtime_tracker::MemoryTracker;
32+
use crate::base::runtime_tracker::MemStat;
3333

3434
/// Methods to spawn tasks.
3535
pub trait TrySpawn {
@@ -82,18 +82,14 @@ pub struct Runtime {
8282
handle: Handle,
8383

8484
/// Memory tracker for this runtime
85-
tracker: Arc<MemoryTracker>,
85+
tracker: Arc<MemStat>,
8686

8787
/// Use to receive a drop signal when dropper is dropped.
8888
_dropper: Dropper,
8989
}
9090

9191
impl Runtime {
92-
fn create(
93-
name: Option<String>,
94-
tracker: Arc<MemoryTracker>,
95-
builder: &mut Builder,
96-
) -> Result<Self> {
92+
fn create(name: Option<String>, tracker: Arc<MemStat>, builder: &mut Builder) -> Result<Self> {
9793
let runtime = builder
9894
.build()
9995
.map_err(|tokio_error| ErrorCode::TokioError(tokio_error.to_string()))?;
@@ -130,25 +126,25 @@ impl Runtime {
130126
})
131127
}
132128

133-
fn tracker_builder(mem_tracker: Arc<MemoryTracker>) -> tokio::runtime::Builder {
129+
fn tracker_builder(mem_stat: Arc<MemStat>) -> tokio::runtime::Builder {
134130
let mut builder = tokio::runtime::Builder::new_multi_thread();
135131
builder
136132
.enable_all()
137-
.on_thread_start(mem_tracker.on_start_thread());
133+
.on_thread_start(mem_stat.on_start_thread());
138134

139135
builder
140136
}
141137

142-
pub fn get_tracker(&self) -> Arc<MemoryTracker> {
138+
pub fn get_tracker(&self) -> Arc<MemStat> {
143139
self.tracker.clone()
144140
}
145141

146142
/// Spawns a new tokio runtime with a default thread count on a background
147143
/// thread and returns a `Handle` which can be used to spawn tasks via
148144
/// its executor.
149145
pub fn with_default_worker_threads() -> Result<Self> {
150-
let mem_tracker = MemoryTracker::create();
151-
let mut runtime_builder = Self::tracker_builder(mem_tracker.clone());
146+
let mem_stat = MemStat::create();
147+
let mut runtime_builder = Self::tracker_builder(mem_stat.clone());
152148

153149
#[cfg(debug_assertions)]
154150
{
@@ -160,13 +156,13 @@ impl Runtime {
160156
}
161157
}
162158

163-
Self::create(None, mem_tracker, &mut runtime_builder)
159+
Self::create(None, mem_stat, &mut runtime_builder)
164160
}
165161

166162
#[allow(unused_mut)]
167163
pub fn with_worker_threads(workers: usize, mut thread_name: Option<String>) -> Result<Self> {
168-
let mem_tracker = MemoryTracker::create();
169-
let mut runtime_builder = Self::tracker_builder(mem_tracker.clone());
164+
let mem_stat = MemStat::create();
165+
let mut runtime_builder = Self::tracker_builder(mem_stat.clone());
170166

171167
#[cfg(debug_assertions)]
172168
{
@@ -184,7 +180,7 @@ impl Runtime {
184180

185181
Self::create(
186182
thread_name,
187-
mem_tracker,
183+
mem_stat,
188184
runtime_builder.worker_threads(workers),
189185
)
190186
}

0 commit comments

Comments
 (0)