Skip to content

Commit a1a81c2

Browse files
authored
chore(optimizer): snow_plan -> good_plan (#17611)
rename to good_plan
1 parent 1e27d71 commit a1a81c2

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

src/query/service/tests/it/sql/planner/optimizer/data/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ raw_plan: | # Expected raw plan
4343
optimized_plan: | # Expected optimized plan
4444
...
4545
46-
snow_plan: | # Optional expected snowflake plan
46+
good_plan: | # Optional expected good plan
4747
...
4848
```
4949
@@ -64,4 +64,4 @@ To add a new test case:
6464
If the expected output of a test changes (e.g., due to optimizer improvements):
6565

6666
1. Run the test to see the actual output.
67-
2. Update the `raw_plan`, `optimized_plan`, or `snow_plan` field in the YAML file to match the actual output.
67+
2. Update the `raw_plan`, `optimized_plan`, or `good_plan` field in the YAML file to match the actual output.

src/query/service/tests/it/sql/planner/optimizer/data/yaml/q1.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ optimized_plan: |
251251
└── limit: NONE
252252
253253
# Converted from tabular format to tree format based on parent-child relationships
254-
snow_plan: |
254+
good_plan: |
255255
Result
256256
└── SortWithLimit [sortKey: (CUSTOMER.C_CUSTOMER_ID ASC NULLS LAST), rowCount: 100]
257257
└── InnerJoin [joinKey: (CTR1.CTR_CUSTOMER_SK = CUSTOMER.C_CUSTOMER_SK)]

src/query/service/tests/it/sql/planner/optimizer/data/yaml/q3.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ optimized_plan: |
167167
├── order by: []
168168
└── limit: NONE
169169
170-
snow_plan: |
170+
good_plan: |
171171
Result [output: DT.D_YEAR, ITEM.I_BRAND_ID, ITEM.I_BRAND, SUM(...)]
172172
└── SortWithLimit [limit: 100]
173173
├── sort keys: [DT.D_YEAR ASC NULLS LAST, SUM(SS_EXT_SALES_PRICE) DESC NULLS FIRST, ITEM.I_BRAND_ID ASC NULLS LAST]

src/query/service/tests/it/sql/planner/optimizer/tpcds_test.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ struct YamlTestCase {
4848
column_statistics: HashMap<String, YamlColumnStatistics>,
4949
raw_plan: String,
5050
optimized_plan: String,
51-
snow_plan: Option<String>,
51+
good_plan: Option<String>,
5252
}
5353

5454
/// YAML representation of table statistics

0 commit comments

Comments
 (0)