Skip to content

feat(query): variant support extension types(Decimal, Binary, Date, Timestamp, Interval) #17835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 27, 2025

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Apr 23, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • variant support extension types(Decimal, Binary, Date, Timestamp, Timestamp, Interval)
  • add i256 type as a wrap of ethnum::i256, to impl BorshSerialize and BorshDeserialize
  • add new function as_binary, is_binary, as_date, is_date, as_timestamp, is_timestamp, as_interval, is_interval to convert variant value to other type value.
  • fixes: #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Apr 23, 2025
@b41sh b41sh force-pushed the feat-variant-ext-types branch from 449d4dd to 776d678 Compare April 25, 2025 08:11
@b41sh b41sh marked this pull request as ready for review April 25, 2025 08:20
@b41sh b41sh requested review from youngsofun and sundy-li April 25, 2025 08:39
@b41sh b41sh merged commit 163d0d8 into databendlabs:main Apr 27, 2025
95 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants