Skip to content

fix(query): the stage utilized by the history table needs to be restricted #18380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Jul 17, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

The history table uses a stage named log_1f93b76af0bd4b1d8e018667865fbc65 to store intermediate raw log files, and access to this stage need also be controlled by the privilege system.

In pr:

Only ACCOUNT_ADMIN role or system_history inner user can operator the system_history stage.

fixes: #18379

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jul 17, 2025
@TCeason TCeason force-pushed the system_history_stage branch from a45f351 to f78130d Compare July 17, 2025 12:05
@TCeason TCeason requested review from youngsofun and dqhl76 July 17, 2025 12:08
@TCeason TCeason force-pushed the system_history_stage branch from f78130d to 2e6983a Compare July 17, 2025 12:51
…icted

The history table uses a stage named log_1f93b76af0bd4b1d8e018667865fbc65 to store intermediate raw log files, and access to this stage need also be controlled by the privilege system.
@TCeason TCeason force-pushed the system_history_stage branch from 2e6983a to 1185126 Compare July 17, 2025 23:58
Copy link
Collaborator

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TCeason TCeason merged commit 39d0a75 into databendlabs:main Jul 21, 2025
164 of 166 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: the stage utilized by the history table needs to be restricted
3 participants