-
Notifications
You must be signed in to change notification settings - Fork 830
feat(query): better script engine with dynamic schema support #18838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundy-li
commented
Oct 15, 2025
| sender.abort(); | ||
| } | ||
| Some(Ok(block)) => { | ||
| if is_dynamic_schema { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youngsofun for dynamic schema, please review this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
youngsofun
approved these changes
Oct 20, 2025
forsaken628
approved these changes
Oct 20, 2025
TCeason
reviewed
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-chore
this PR only has small changes that no need to record, like coding styles.
pr-feature
this PR introduces a new feature to the codebase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This PR implements a better script engine with enhanced support for dynamic schema handling and improved AST parsing for stored procedures and script execution.
Key improvements:
EXECUTE IMMEDIATEstatements that can return different schemas based on runtime executionIdentifierinstead ofStringfor better type safety and script variable supportdeclare cursor from stmt
declare cursor from resultset, open fetch and close
iterator the cursor:
Major changes:
ExecuteImmediateStmtto accept expressions instead of plain stringsScriptBlockOrStmtenum to handle both script blocks and individual statementsIdentifiertypes for namesTests
Type of change
This change is