style fix: avoid indentation by returning early when ok is false

Author: anton-107

bundle/config/mutator/resourcemutator/configure_dashboards_serialized_dashboard.go

@@ -24,7 +24,7 @@ func (c configureDashboardSerializedDashboard) Name() string {
 	return "ConfigureDashboardSerializedDashboard"
 }
 
-func (c configureDashboardSerializedDashboard) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
+func (c configureDashboardSerializedDashboard) Apply(_ context.Context, b *bundle.Bundle) diag.Diagnostics {
 	var diags diag.Diagnostics
 
 	pattern := dyn.NewPattern(
@@ -39,34 +39,35 @@ func (c configureDashboardSerializedDashboard) Apply(ctx context.Context, b *bun
 			// Include "serialized_dashboard" field if "file_path" is set.
 			// Note: the Terraform resource supports "file_path" natively, but we read the contents of the dashboard here
 			// to cover the use case of deployments from the workspace
-			if path, ok := v.Get(filePathFieldName).AsString(); ok {
+			path, ok := v.Get(filePathFieldName).AsString()
+			if !ok {
+				return v, nil
+			}
 
-				contents, err := b.SyncRoot.ReadFile(path)
-				if err != nil {
-					return dyn.InvalidValue, fmt.Errorf("failed to read serialized dashboard from file_path %s: %w", path, err)
-				}
+			contents, err := b.SyncRoot.ReadFile(path)
+			if err != nil {
+				return dyn.InvalidValue, fmt.Errorf("failed to read serialized dashboard from file_path %s: %w", path, err)
+			}
 
-				v, err := dyn.Set(v, serializedDashboardFieldName, dyn.V(string(contents)))
-				if err != nil {
-					return dyn.InvalidValue, fmt.Errorf("failed to set serialized_dashboard: %w", err)
-				}
+			v, err = dyn.Set(v, serializedDashboardFieldName, dyn.V(string(contents)))
+			if err != nil {
+				return dyn.InvalidValue, fmt.Errorf("failed to set serialized_dashboard: %w", err)
+			}
 
-				// Drop the "file_path" field. It is mutually exclusive with "serialized_dashboard".
-				return dyn.Walk(v, func(p dyn.Path, v dyn.Value) (dyn.Value, error) {
-					switch len(p) {
-					case 0:
-						return v, nil
-					case 1:
-						if p[0] == dyn.Key(filePathFieldName) {
-							return v, dyn.ErrDrop
-						}
+			// Drop the "file_path" field. It is mutually exclusive with "serialized_dashboard".
+			return dyn.Walk(v, func(p dyn.Path, v dyn.Value) (dyn.Value, error) {
+				switch len(p) {
+				case 0:
+					return v, nil
+				case 1:
+					if p[0] == dyn.Key(filePathFieldName) {
+						return v, dyn.ErrDrop
 					}
+				}
 
-					// Skip everything else.
-					return v, dyn.ErrSkip
-				})
-			}
-			return v, nil
+				// Skip everything else.
+				return v, dyn.ErrSkip
+			})
 		})
 	})