acc: Use large numbers for jobId & testId in testserver (#2922)

Author: denik

acceptance/acceptance_test.go

@@ -31,6 +31,7 @@ import (
 	"github.com/databricks/cli/internal/testutil"
 	"github.com/databricks/cli/libs/auth"
 	"github.com/databricks/cli/libs/testdiff"
+	"github.com/databricks/cli/libs/testserver"
 	"github.com/databricks/cli/libs/utils"
 	"github.com/stretchr/testify/require"
 )
@@ -439,9 +440,15 @@ func runTest(t *testing.T,
 	// Must be added PrepareReplacementsUser, otherwise conflicts with [USERNAME]
 	testdiff.PrepareReplacementsUUID(t, &repls)
 
-	// User replacements come last:
+	// User replacements:
 	repls.Repls = append(repls.Repls, config.Repls...)
 
+	// Apply these after user replacements in case user replacement capture something like "Job \d+"
+	for offset := range 5 {
+		repls.Set(strconv.Itoa(testserver.TestJobID+offset), fmt.Sprintf("[TEST_JOB_ID+%d]", offset))
+		repls.Set(strconv.Itoa(testserver.TestRunID+offset), fmt.Sprintf("[TEST_RUN_ID+%d]", offset))
+	}
+
 	// Save replacements to temp test directory so that it can be read by diff.py
 	replsJson, err := json.MarshalIndent(repls.Repls, "", "  ")
 	require.NoError(t, err)

acceptance/bundle/deploy/experimental-python/output.txt

@@ -8,7 +8,7 @@ Deployment complete!
 >>> [CLI] jobs list --output json
 [
   {
-    "job_id": 1,
+    "job_id": [TEST_JOB_ID+0],
     "settings": {
       "deployment": {
         "kind": "BUNDLE",

acceptance/bundle/deploy/fail-on-active-runs/output.txt

@@ -6,7 +6,7 @@ Updating deployment state...
 Deployment complete!
 
 >>> errcode [CLI] bundle deploy --fail-on-active-runs
-Error: job 1 is running
+Error: job [TEST_JOB_ID+0] is running
 
 
 Exit code: 1

acceptance/bundle/deploy/python-notebook/output.txt

@@ -8,7 +8,7 @@ Deployment complete!
 >>> [CLI] jobs list --output json
 [
   {
-    "job_id": 1,
+    "job_id": [TEST_JOB_ID+0],
     "settings": {
       "deployment": {
         "kind": "BUNDLE",

acceptance/bundle/resources/jobs/output.txt

@@ -39,7 +39,7 @@ Deployment complete!
   "method": "POST",
   "path": "/api/2.2/jobs/create"
 }
-jobs foo id='1' name='foo'
+jobs foo id='[TEST_JOB_ID+0]' name='foo'
 
 === Update trigger.periodic.unit and re-deploy
 >>> update_file.py databricks.yml DAYS HOURS
@@ -53,7 +53,7 @@ Deployment complete!
 >>> print_requests
 {
   "body": {
-    "job_id": 1,
+    "job_id": [TEST_JOB_ID+0],
     "new_settings": {
       "deployment": {
         "kind": "BUNDLE",
@@ -87,4 +87,4 @@ Deployment complete!
   "method": "POST",
   "path": "/api/2.2/jobs/reset"
 }
-jobs foo id='1' name='foo'
+jobs foo id='[TEST_JOB_ID+0]' name='foo'

acceptance/bundle/run/basic/output.txt

@@ -13,7 +13,7 @@ Updating deployment state...
 Deployment complete!
 
 >>> [CLI] bundle run foo
-Run URL: [DATABRICKS_URL]/job/run/1
+Run URL: [DATABRICKS_URL]/job/run/[TEST_RUN_ID+0]
 
 [DATE] HH:MM:SS "run-name" TERMINATED
 
@@ -25,7 +25,7 @@ Exit code: 1
 
 === resource key with parameters
 >>> [CLI] bundle run foo -- arg1 arg2
-Run URL: [DATABRICKS_URL]/job/run/2
+Run URL: [DATABRICKS_URL]/job/run/[TEST_RUN_ID+1]
 
 [DATE] HH:MM:SS "run-name" TERMINATED
 

acceptance/bundle/telemetry/deploy-no-uuid/out.telemetry.txt

@@ -27,7 +27,7 @@
         "resource_dashboard_count": 0,
         "resource_app_count": 0,
         "resource_job_ids": [
-          "1"
+          "[TEST_JOB_ID+0]"
         ],
         "experimental": {
           "configuration_file_count": 1,

acceptance/bundle/telemetry/deploy/out.telemetry.txt

@@ -27,9 +27,9 @@
         "resource_dashboard_count": 0,
         "resource_app_count": 0,
         "resource_job_ids": [
-          "1",
-          "2",
-          "3"
+          "[TEST_JOB_ID+0]",
+          "[TEST_JOB_ID+1]",
+          "[TEST_JOB_ID+2]"
         ],
         "resource_pipeline_ids": [
           "[UUID]",

libs/testserver/fake_workspace.go

@@ -17,6 +17,16 @@ import (
 	"github.com/databricks/databricks-sdk-go/service/workspace"
 )
 
+// 4611686018427387911 == 2 ** 62 + 7
+// 2305843009213693969 == 2 ** 61 + 17
+// This values cannot be represented by float64, so they can test incorrect use of json parsing
+// (encoding/json without options parses numbers into float64)
+// These are also easier to spot / replace in test output compared to numbers with one or few digits.
+const (
+	TestJobID = 4611686018427387911
+	TestRunID = 2305843009213693969
+)
+
 // FakeWorkspace holds a state of a workspace for acceptance tests.
 type FakeWorkspace struct {
 	mu  sync.Mutex
@@ -100,8 +110,8 @@ func NewFakeWorkspace(url string) *FakeWorkspace {
 		files:        map[string][]byte{},
 		Jobs:         map[int64]jobs.Job{},
 		JobRuns:      map[int64]jobs.Run{},
-		nextJobId:    1,
-		nextJobRunId: 1,
+		nextJobId:    TestJobID,
+		nextJobRunId: TestRunID,
 		Pipelines:    map[string]pipelines.PipelineSpec{},
 		Monitors:     map[string]catalog.MonitorInfo{},
 		Apps:         map[string]apps.App{},