extract setSpecDefaults

Author: denik

libs/testserver/pipelines.go

@@ -40,21 +40,14 @@ func (s *FakeWorkspace) PipelineCreate(req Request) Response {
 	r.Spec = &spec
 
 	pipelineId := uuid.New().String()
-	spec.Id = pipelineId
 	r.PipelineId = pipelineId
 	r.CreatorUserName = "tester@databricks.com"
 	r.LastModified = time.Now().UnixMilli()
 	r.Name = r.Spec.Name
 	r.RunAsUserName = "tester@databricks.com"
 	r.State = "IDLE"
 
-	// If the pipeline definition does not specify a catalog, it switches to Hive metastore mode
-	// and if the storage location is not specified, API automatically generates a storage location
-	// (ref: https://docs.databricks.com/gcp/en/dlt/hive-metastore#specify-a-storage-location)
-	if spec.Storage == "" && spec.Catalog == "" {
-		spec.Storage = "dbfs:/pipelines/" + pipelineId
-	}
-	s.Pipelines[pipelineId] = r
+	setSpecDefaults(&spec, pipelineId)
 
 	return Response{
 		Body: pipelines.CreatePipelineResponse{
@@ -63,6 +56,16 @@ func (s *FakeWorkspace) PipelineCreate(req Request) Response {
 	}
 }
 
+func setSpecDefaults(spec *pipelines.PipelineSpec, pipelineId string) {
+	spec.Id = pipelineId
+	// If the pipeline definition does not specify a catalog, it switches to Hive metastore mode
+	// and if the storage location is not specified, API automatically generates a storage location
+	// (ref: https://docs.databricks.com/gcp/en/dlt/hive-metastore#specify-a-storage-location)
+	if spec.Storage == "" && spec.Catalog == "" {
+		spec.Storage = "dbfs:/pipelines/" + pipelineId
+	}
+}
+
 func (s *FakeWorkspace) PipelineUpdate(req Request, pipelineId string) Response {
 	defer s.LockUnlock()()
 
@@ -82,10 +85,7 @@ func (s *FakeWorkspace) PipelineUpdate(req Request, pipelineId string) Response
 		}
 	}
 
-	spec.Id = pipelineId
-	if spec.Storage == "" && spec.Catalog == "" {
-		spec.Storage = "dbfs:/pipelines/" + pipelineId
-	}
+	setSpecDefaults(&spec, pipelineId)
 
 	item.Spec = &spec
 	s.Pipelines[pipelineId] = item