Skip to content

Simplify config-file telemetry acceptance test #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Apr 1, 2025

Changes

This PR:

  1. Modifies config-file telemetry acceptance test to assert only on the entry. Other tests already assert on the entire payload.
  2. Removes set +o pipeline which I forgot to remove from Track number of YAML configuration files in a bundle #2589 before merging.

Why

Simpler test that's easier to maintain.

@shreyas-goenka shreyas-goenka changed the title Cleanup SIGPIPE comment Simplify config file telemetry acceptance test Apr 1, 2025
@shreyas-goenka shreyas-goenka changed the title Simplify config file telemetry acceptance test Simplify config-file telemetry acceptance test Apr 1, 2025
@shreyas-goenka shreyas-goenka marked this pull request as ready for review April 1, 2025 15:05
@denik
Copy link
Contributor

denik commented Apr 2, 2025

Looks ok, please resolve the conflicts for review.

@denik denik marked this pull request as draft April 2, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants