Allows different ports in host mismatch check #2681
Closed
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
commented
Apr 8, 2025
| @@ -37,7 +37,7 @@ func MatchHost(host1, host2 string) bool { | |||
| if err != nil { | |||
| return false | |||
| } | |||
| return u1.Host == u2.Host | |||
| return u1.Hostname() == u2.Hostname() | |||
There was a problem hiding this comment.
Do we have any cases when port difference should be not allowed?
There was a problem hiding this comment.
In general different port means different URL, so https://x.com should be equal to https://x.com:443 but not to any other port.
denik
reviewed
Apr 16, 2025
| @@ -28,6 +28,7 @@ func TestNormalizeHost(t *testing.T) { | |||
| func TestMatchHost(t *testing.T) { | |||
| assert.True(t, MatchHost("https://foo.com", "https://foo.com")) | |||
| assert.True(t, MatchHost("https://foo.com", "foo.com")) | |||
| assert.True(t, MatchHost("https://foo.com", "https://foo.com:443")) | |||
There was a problem hiding this comment.
Can you add a test for
assert.False(t, MatchHost("https://foo.com", "https://foo.com:4430"))
assert.False(t, MatchHost("https://foo.com", "https://foo.com:80"))
| @@ -37,7 +37,7 @@ func MatchHost(host1, host2 string) bool { | |||
| if err != nil { | |||
| return false | |||
| } | |||
| return u1.Host == u2.Host | |||
| return u1.Hostname() == u2.Hostname() | |||
There was a problem hiding this comment.
In general different port means different URL, so https://x.com should be equal to https://x.com:443 but not to any other port.
|
We can probably close this one as original feature for DATABRICKS_HOST mismatch check was reverted |
|
Closing as DATABRICKS_HOST mismatch check was reverted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allow different ports to be defined in profile/env and config host
Why
In Web Terminal
DATABRICKS_HOSTvariable is set with explicit 443 portTests
Unit test